Code review comment for lp://qastaging/~bac/launchpad/bug-490521

Revision history for this message
Brad Crittenden (bac) wrote :

= Summary =

For a package that has been connected to an upstream project an indicator for the
different attributes is shown in the "Upstream connections" portlet.

== Proposed fix ==

Include the new 'yes-no' TALES macro written by Curtis and use it to visually
indicate whether bug supervisor, bug tracker, and the branch for the series are
populated.

== Pre-implementation notes ==

Lots of discussions with Curtis and Edwin.

== Implementation details ==

Hack in hard-coded uses of the new macro. If this UI design is accepted after
testing on edge it will be refactored into a new view so that the functionality can
be used elsewhere.

== Tests ==

bin/test -vvm lp.registry -t xx-sourcepackage-packaging.txt \
   -t sourcepackage-views.txt

== Demo and Q/A ==

See it in action at https://launchpad.dev/ubuntu/hoary/+source/netapplet

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/registry/browser/sourcepackage.py
  lib/lp/registry/stories/packaging/xx-sourcepackage-packaging.txt
  lib/lp/app/templates/base-layout-macros.pt
  lib/lp/registry/browser/tests/sourcepackage-views.txt
  lib/lp/registry/templates/sourcepackage-portlet-associations.pt

== Pylint notices ==

lib/lp/registry/browser/sourcepackage.py
    29: [F0401] Unable to import 'lazr.restful.interface' (No module named restful)

« Back to merge proposal