Merge lp://qastaging/~bac/lp2kanban/no-zombies into lp://qastaging/~launchpad/lp2kanban/trunk
Proposed by
Brad Crittenden
| Status: | Merged |
|---|---|
| Merged at revision: | 69 |
| Proposed branch: | lp://qastaging/~bac/lp2kanban/no-zombies |
| Merge into: | lp://qastaging/~launchpad/lp2kanban/trunk |
| Diff against target: |
163 lines (+63/-4) 6 files modified
examples/config.ini (+3/-0) src/lp2kanban/bugs2cards.py (+15/-1) src/lp2kanban/kanban.py (+8/-0) src/lp2kanban/tests/common.py (+3/-1) src/lp2kanban/tests/test_bugs2cards.py (+32/-0) src/lp2kanban/tests/test_cards2workitems.py (+2/-2) |
| To merge this branch: | bzr merge lp://qastaging/~bac/lp2kanban/no-zombies |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Graham Binns (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
* Add a new option 'move_cards'. If it is off then cards will be updated for assignees, description, etc, but won't change lanes. The default is off.
* Don't move cards that belong to an archived board to avoid the problem of cards being reanimated and moved to the done:done lane.
Q: in save_board do we really need to loop over all cards in a board or just those linked to LP?
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi Brad,
Thanks for this; r=me.
60 + # It is important that we loop over all cards, not just those from
61 + # getCardsWithExt
62 + # XXX GRAHAM IS THIS TRUE? WOULD LOVE TO USE THE SMALLER SET.
63 + for card in board.cards:
The blueprint work items code explicitly saves each card it touches, so you're safe to use getCardsWithExt
Thanks for fixing my existant/existent typo (though strangely existant doesn't come up as a spelling error (even though I know it's incorrect). Weird).