LP2Kanban

Merge lp://qastaging/~bac/lp2kanban/pick-newest-mp into lp://qastaging/~launchpad/lp2kanban/trunk

  1. pick-newest-mp
  2. Merge into trunk
Proposed by Brad Crittenden
Status: Merged
Merged at revision: 64
Proposed branch: lp://qastaging/~bac/lp2kanban/pick-newest-mp
Merge into: lp://qastaging/~launchpad/lp2kanban/trunk
Diff against target: 146 lines (+53/-18)
3 files modified
setup.py (+1/-0)
src/lp2kanban/bugs2cards.py (+18/-17)
src/lp2kanban/tests/test_bugs2cards.py (+34/-1)
To merge this branch: bzr merge lp://qastaging/~bac/lp2kanban/pick-newest-mp
Reviewer Review Type Date Requested Status
Benji York (community) code Approve
Review via email: mp+143925@code.qastaging.launchpad.net

Description of the change

If there are multiple active merge proposals, choose the most recent to link.

In testing I found a bug where a single mp_info was being reused, so the latest added to the list was always the winner.

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

The branch looks great.

I suggest ignoring the two-lines-beween-module-globals rule for
"constants" -- just as we do for imports.

review: Approve (code)
lp://qastaging/~bac/lp2kanban/pick-newest-mp updated
65. By Brad Crittenden

lint

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches