Merge lp://qastaging/~bac/tarmac/make_treedir into lp://qastaging/tarmac
| Status: | Merged |
|---|---|
| Approved by: | Paul Hummer |
| Approved revision: | 401 |
| Merged at revision: | 400 |
| Proposed branch: | lp://qastaging/~bac/tarmac/make_treedir |
| Merge into: | lp://qastaging/tarmac |
| Diff against target: |
233 lines (+64/-24) 8 files modified
HACKING (+11/-0) docs/introduction.txt (+23/-18) docs/writingplugins.txt (+1/-1) tarmac/bin/commands.py (+2/-2) tarmac/branch.py (+5/-0) tarmac/config.py (+2/-2) tarmac/tests/test_branch.py (+19/-0) tarmac/tests/test_commands.py (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~bac/tarmac/make_treedir |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Hummer | Approve | ||
|
Review via email:
|
|||
Commit message
If the dirname() portion of tree_dir does not exist, then create it in create_tree.
Description of the change
If the dirname() portion of tree_dir does not exist, then create it in create_tree.
Also made some changes to the documentation that I think helps clarify things. One change that may be controversial is to *not* use 'tarmac' as the example when explaining the configuration as it is too subtle for new users to see the difference between the [Tarmac] stanzas and the subsequent [lp:tarmac] parts. Perhaps just an introductory statement would've sufficed but it seemed reasonable to avoid the confusion all together.
Some line changes are due to deleting trailing whitespace, which my editor does automatically. Sorry for polluting the diff with those. Similarly, I removed some apostrophes (single-quotes) contained within docstrings as they appear as unbalanced quotes.
| Paul Hummer (rockstar) | # |
| Brad Crittenden (bac) wrote | # |
Thanks for the review Paul. I assume you'll merge it into trunk shortly?