Qt bindings for libdee

Merge lp://qastaging/~ballogy/dee-qt/fix-imports-dir-location into lp://qastaging/dee-qt/0.2

  1. fix-imports-dir-location
  2. Merge into trunk
Proposed by Balló György
Status: Rejected
Rejected by: Albert Astals Cid
Proposed branch: lp://qastaging/~ballogy/dee-qt/fix-imports-dir-location
Merge into: lp://qastaging/dee-qt/0.2
Diff against target: 23 lines (+11/-1)
1 file modified
CMakeLists.txt (+11/-1)
To merge this branch: bzr merge lp://qastaging/~ballogy/dee-qt/fix-imports-dir-location
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Disapprove
Gerry Boland (community) Needs Fixing
Review via email: mp+85354@code.qastaging.launchpad.net

Description of the change

This change replace the hard-coded imports dir location with QT_INSTALL_IMPORTS variable. I need it for Arch Linux, because it uses /usr/lib/qt/imports instead of /usr/lib/qt4/imports

It's similar to the already accepted proposals for bamf-qt and gconf-qt:
https://code.launchpad.net/~ballogy/bamf-qt/fix-imports-dir-location/+merge/83248
https://code.launchpad.net/~ballogy/gconf-qt/fix-imports-dir-location/+merge/83253

To post a comment you must log in.
Revision history for this message
Olivier Tilloy (osomon) wrote :

Let’s wait on the decision regarding https://code.launchpad.net/~kamstrup/bamf-qt/fixes-for-jhbuild/+merge/85614 to see if we want to adopt a similar solution. We would thus avoid a two-step process to fix the build both for ArchLinux packaging and for use with jhbuild.

Revision history for this message
Gerry Boland (gerboland) wrote :

Hi György,
I prefer the solution given in https://code.launchpad.net/~kamstrup/bamf-qt/fixes-for-jhbuild/+merge/85614 as it is more flexible. If you can perform the same trick here, it would be great.

review: Needs Fixing
lp://qastaging/~ballogy/dee-qt/fix-imports-dir-location updated
58. By Balló György

Allow overwrite the imports directory by setting -DQT_IMPORTS_DIR on the
cmake commend line

Revision history for this message
Balló György (ballogy) wrote :

Now I modified my proposal according to the another one.

Revision history for this message
Albert Astals Cid (aacid) wrote :

Is this still needed? If so i guess you should try to retarget it to the current master branch and not to 0.2

Revision history for this message
Albert Astals Cid (aacid) wrote :

No answer in months, so i guess no.

review: Disapprove

Unmerged revisions

58. By Balló György

Allow overwrite the imports directory by setting -DQT_IMPORTS_DIR on the
cmake commend line

57. By Balló György

Query qmake instead of using QT_IMPORTS_DIR variable

56. By Balló György

Use QT_IMPORTS_DIR variable to locate imports dir

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches