Merge lp://qastaging/~ballogy/gloobus-sushi/pygobject3-port into lp://qastaging/gloobus-sushi

Dear György,
Since I'm a bit away from the project, I just added you to gloobus
developers members, so you can accept the merges reviews and do them
yourself.

Thank you so much for contributing with us!

On Sat, Dec 20, 2014 at 10:26 PM, György Balló <email address hidden> wrote:
>
> György Balló has proposed merging
> lp:~ballogy/gloobus-sushi/pygobject3-port into lp:gloobus-sushi.
>
> Requested reviews:
> Gloobus Developers (gloobus-dev)
>
> For more details, see:
>
> https://code.launchpad.net/~ballogy/gloobus-sushi/pygobject3-port/+merge/245282
>
> Port to pygobject3
>
> Similar to
> https://code.launchpad.net/~ballogy/gloobus-preview/pygobject3-port/+merge/245281
> so pygobject2 will be no longer a dependency.
> --
> Your team Gloobus Developers is requested to review the proposed merge of
> lp:~ballogy/gloobus-sushi/pygobject3-port into lp:gloobus-sushi.
>
> === modified file 'src/gloobus-sushi.py'
> --- src/gloobus-sushi.py 2011-10-04 22:46:39 +0000
> +++ src/gloobus-sushi.py 2014-12-20 21:25:40 +0000
> @@ -16,7 +16,7 @@
>
> import dbus
> import dbus.service
> -import gobject
> +from gi.repository import GObject
> import os
>
> from dbus.mainloop.glib import DBusGMainLoop
> @@ -28,7 +28,7 @@
> def __init__(self):
> bus_name = dbus.service.BusName(DBUS_NAME, bus=dbus.SessionBus())
> super(DBusWrapper, self).__init__(bus_name, DBUS_PATH)
> - self.loop = gobject.MainLoop()
> + self.loop = GObject.MainLoop()
> self.loop.run()
>
> @dbus.service.method(DBUS_NAME)
>
>
>

--

*Jordi* *Puigdellívol*
<email address hidden>

> Dear György,
> Since I'm a bit away from the project, I just added you to gloobus
> developers members, so you can accept the merges reviews and do them
> yourself.
>
> Thank you so much for contributing with us!

Thanks, then I'll merge my patches. I plan to do some other changes (e.g. port gloobus-preview to gstreamer 1.0). Do you have any plan to make a new release in the near future?

That sounds great,

About a future release, since I’ve been really out of the project, I don’t have any in mind, but I think we can release a new one with all your patches,
What do you say?

—

Jordi Puigdellívol
<email address hidden>

De: György Balló <email address hidden>
Respondre: <email address hidden> <email address hidden>>
Data: 21 de desembre de 2014 at 19:13:25
Per a: <email address hidden> <email address hidden>>
Tema:  Re: [Merge] lp:~ballogy/gloobus-sushi/pygobject3-port into lp:gloobus-sushi

> Dear György,
> Since I'm a bit away from the project, I just added you to gloobus
> developers members, so you can accept the merges reviews and do them
> yourself.
>
> Thank you so much for contributing with us!

Thanks, then I'll merge my patches. I plan to do some other changes (e.g. port gloobus-preview to gstreamer 1.0). Do you have any plan to make a new release in the near future?
--
https://code.launchpad.net/~ballogy/gloobus-sushi/pygobject3-port/+merge/245282
Your team Gloobus Developers is requested to review the proposed merge of lp:~ballogy/gloobus-sushi/pygobject3-port into lp:gloobus-sushi.

Okay. I'm still working on some improvements. I would like to implement the following things:

- Remove taglib dependency (comment out the code). I found that GStreamer's tag parse works reliable now.

- Merge gloobus-sushi into gloobus-preview. gloobus-sushi is just a small python script and a D-Bus service file, so I think it could be added into the main project.

- Remove GConf dependency. The window buttons layout setting on GNOME 3 is stored in GSettings.

- Add some more audio format that supported by GStreamer.

And maybe some bug fixes. After that, we can make a new release.

That sounds really good,
Let me know when it is done so I can contact the major linux distributions to update their package

Thanks!

—

Jordi Puigdellívol
<email address hidden>

De: György Balló <email address hidden>
Respondre: <email address hidden> <email address hidden>>
Data: 22 de desembre de 2014 at 11:32:18
Per a: György Balló <email address hidden>>
Tema:  Re: [Merge] lp:~ballogy/gloobus-sushi/pygobject3-port into lp:gloobus-sushi

Okay. I'm still working on some improvements. I would like to implement the following things:

- Remove taglib dependency (comment out the code). I found that GStreamer's tag parse works reliable now.

- Merge gloobus-sushi into gloobus-preview. gloobus-sushi is just a small python script and a D-Bus service file, so I think it could be added into the main project.

- Remove GConf dependency. The window buttons layout setting on GNOME 3 is stored in GSettings.

- Add some more audio format that supported by GStreamer.

And maybe some bug fixes. After that, we can make a new release.
--
https://code.launchpad.net/~ballogy/gloobus-sushi/pygobject3-port/+merge/245282
Your team Gloobus Developers is requested to review the proposed merge of lp:~ballogy/gloobus-sushi/pygobject3-port into lp:gloobus-sushi.

Now I implemented everything what I wanted. I think we can make a new release for version 0.5:
https://bugs.launchpad.net/gloobus-preview/+milestone/0.5