Online Accounts: GNOME Control Center

Merge lp://qastaging/~ballogy/gnome-control-center-signon/make-ccpanel-optional into lp://qastaging/gnome-control-center-signon

  1. make-ccpanel-optional
  2. Merge into trunk
Proposed by Balló György
Status: Rejected
Rejected by: David King
Proposed branch: lp://qastaging/~ballogy/gnome-control-center-signon/make-ccpanel-optional
Merge into: lp://qastaging/gnome-control-center-signon
Diff against target: 172 lines (+69/-12)
7 files modified
Makefile.am (+26/-7)
configure.ac (+29/-2)
data/com.canonical.webcredentials.capture.service (+0/-3)
data/com.canonical.webcredentials.capture.service.in (+3/-0)
data/credentials-preferences.desktop.in.in (+9/-0)
po/POTFILES.in (+1/-0)
po/POTFILES.skip (+1/-0)
To merge this branch: bzr merge lp://qastaging/~ballogy/gnome-control-center-signon/make-ccpanel-optional
Reviewer Review Type Date Requested Status
David King (community) Needs Fixing
Review via email: mp+130721@code.qastaging.launchpad.net

Description of the change

This change makes the Control Center panel optional. If libgnome-control-center is not available on the system, then builds a stand-alone application called 'credentials-preferences'. The tester code is used from deja-dup[1].

The reason why I request:
GNOME developers disallowed external panels[2], so the development files for libgnome-control-center are not available on distributions other than Ubuntu. Therefore I can't package this project for Arch Linux without this change.

I tested the patch on Arch Linux, and it works well, except the 'application=' parameter. When the parameter specified, the program fails to run.

[1] http://bazaar.launchpad.net/~deja-dup-hackers/deja-dup/26/view/head:/configure.ac#L107
[2] http://git.gnome.org/browse/gnome-control-center/commit/libgnome-control-center/libgnome-control-center.pc.in?id=606b6fd88d52268b4e7720e18035fe947df030cb

To post a comment you must log in.
Revision history for this message
David King (amigadave) wrote :

There are a few mistakes here (such as removing libcredentials.la from credentials-preference LDADD unconditionally. I will fix those and rework the rest of the commit later today.

review: Needs Fixing
Revision history for this message
Balló György (ballogy) wrote :

Thanks for fixing my patch. I have not tested it when libgnome-control-center is available on the system.

Revision history for this message
David King (amigadave) wrote :

I worked on a new branch which solved this in a slightly different way. I have briefly tested both the with and without control center cases, and they seem to work OK. I filed a bug for this problem (bug 1070729) where we should followup, and I will reject this merge proposal in favour of the one that I will create. Thanks for the report though, it is a bug that needs fixing for UOA on other distributions.

Unmerged revisions

115. By Balló György

Add '--with-extensiondir' parameter

114. By Balló György

Make ccpanel optional

Build ccpanel only if libgnome-control-center present on the
system, otherwise build a stand-alone application.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches