Online Accounts: GNOME Control Center

Merge lp://qastaging/~ballogy/gnome-control-center-signon/no-hardcode-ubuntu into lp://qastaging/gnome-control-center-signon

  1. no-hardcode-ubuntu
  2. Merge into trunk
Proposed by Balló György
Status: Needs review
Proposed branch: lp://qastaging/~ballogy/gnome-control-center-signon/no-hardcode-ubuntu
Merge into: lp://qastaging/gnome-control-center-signon
Diff against target: 74 lines (+8/-8)
3 files modified
help/C/legal-notice.page (+4/-4)
libaccount-plugin/oauth-plugin.c (+1/-1)
src/cc-credentials-account-details-page.vala (+3/-3)
To merge this branch: bzr merge lp://qastaging/~ballogy/gnome-control-center-signon/no-hardcode-ubuntu
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
David King (community) Needs Information
Review via email: mp+137462@code.qastaging.launchpad.net

Description of the change

Generalize the term of Ubuntu

Use the term "computer" instead of "Ubuntu", because the latter confuses users of other GNU/Linux distributions.

Related bug report:
https://bugs.launchpad.net/gnome-control-center-signon/+bug/1076047

To post a comment you must log in.
Revision history for this message
Alberto Mardegan (mardy) wrote :

Thanks György! :-) Looks good to me.

review: Approve
Reply
Revision history for this message
David King (amigadave) wrote :

As this changes the legal notice, we should at least get a signoff from legal before approving it.

review: Needs Information
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://s-jenkins:8080/job/gnome-control-center-signon-autolanding/1/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/1/console
    FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/1/console

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

I modified Jenkins configuration to build in raring.

Reply
Revision history for this message
Balló György (ballogy) wrote :

Is there any progress?

Reply
Revision history for this message
Alberto Mardegan (mardy) wrote :

Hi György. Please see the related bug report for the design team's reply.

In short, we don't want to change that in Ubuntu. If you could come up with another patch which makes "Ubuntu" a variable which can be overridden at build time, we would certainly welcome that.

For the legal notice file, you could probably create a "legal-notice.page.in" file and substitute the "Ubuntu"/"your computer" text via autoconf.

(this is just a suggestion: other solutions which preserve the Ubuntu name when the package is built in Ubuntu are acceptable)

Reply
Revision history for this message
Alberto Mardegan (mardy) :
review: Needs Fixing
Reply
Revision history for this message
Balló György (ballogy) wrote :

Thanks for the response. Unfortunately, I don't have the knowledge how to fix the patch in this way.

It would be nice if upstream developers would solve this problem.

Reply

Unmerged revisions

125. By Balló György

Generalize the term of Ubuntu

Use the term "computer" instead of "Ubuntu", because the latter confuse users of other GNU/Linux distributions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches