Merge lp://qastaging/~ballogy/libappindicator/build-fixes into lp://qastaging/libappindicator/0.5

Proposed by Ted Gould
Status: Merged
Approved by: Ted Gould
Approved revision: 224
Merged at revision: 223
Proposed branch: lp://qastaging/~ballogy/libappindicator/build-fixes
Merge into: lp://qastaging/libappindicator/0.5
Diff against target: 50 lines (+4/-4)
4 files modified
bindings/mono/Makefile.am (+1/-1)
bindings/mono/appindicator-sharp-0.1.pc.in (+1/-1)
bindings/python/Makefile.am (+1/-1)
src/appindicator3-0.1.pc.in (+1/-1)
To merge this branch: bzr merge lp://qastaging/~ballogy/libappindicator/build-fixes
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+90543@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2011-11-22.

Description of the change

This change contains some build fixes for the following problems:

1. Currently, the header files of GTK3 version of the library installed into /usr/include/libappindicator3-0.1 directory, but /usr/include/libappindicator-0.1 defined in appindicator3-0.1.pc.

2. Do not link pyglib explicitly, because the name of the pyglib library may differ between systems, and it seems that it builds without explicit linking.

3. Currently, mono files are installed into a non-standard /usr/lib/cli/appindicator-sharp-0.1 directory instead of /usr/lib/mono/appindicator-sharp. (Debian/Ubuntu should use a distro specific downstream patch.)

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

I don't want to mess with the CLI path. But I'm happy to take the .pc file change.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches