Merge lp://qastaging/~ballogy/libindicate-qt/make-examples-and-tests-optional into lp://qastaging/libindicate-qt
Proposed by
Balló György
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~ballogy/libindicate-qt/make-examples-and-tests-optional |
| Merge into: | lp://qastaging/libindicate-qt |
| Diff against target: |
22 lines (+10/-2) 1 file modified
CMakeLists.txt (+10/-2) |
| To merge this branch: | bzr merge lp://qastaging/~ballogy/libindicate-qt/make-examples-and-tests-optional |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Aurélien Gâteau | Disapprove | ||
|
Review via email:
|
|||
Description of the change
This change makes it possible to disable building examples and tests with '-DBUILD_
To post a comment you must log in.
Unmerged revisions
- 117. By Balló György
-
Make building examples and tests optional
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I don't think building tests and examples add that much time to the overall build time and always building the tests and examples help ensuring they at least do build.
Providing an option to disable building test sends the wrong message: we want developers to run tests, and the first step to run them is to ensure they always build.