Merge lp://qastaging/~barcc/update-manager/all_changes-wrong-use into lp://qastaging/update-manager

Proposed by B. Clausius
Status: Merged
Merged at revision: 2249
Proposed branch: lp://qastaging/~barcc/update-manager/all_changes-wrong-use
Merge into: lp://qastaging/update-manager
Diff against target: 13 lines (+2/-1)
1 file modified
UpdateManager/UpdateManager.py (+2/-1)
To merge this branch: bzr merge lp://qastaging/~barcc/update-manager/all_changes-wrong-use
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+79043@code.qastaging.launchpad.net

Description of the change

changes = self.cache.all_changes[name]

"changes" is not a tuple or list but utf8-encoded byte-string. So to "self.set_changes_buffer(changes_buffer, changes[0], name, changes[1])" are passed single characters in the second and fourth parameter. It might be possible, that in some circumstances changes are not displayed correctly. But here on my computer I just encountered the Warning: "GtkWarning: gtk_text_buffer_emit_insert: assertion `g_utf8_validate (text, len, NULL)' failed". This is because here (german) the first character "Ä" is two bytes long and changes[0] is not valid utf8.

This branch fixes this. The correct changes and srcpkg is used.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks! That looks good, merged into trunk

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: