Merge lp://qastaging/~barry/dialer-app/py3autopilot into lp://qastaging/dialer-app

Proposed by Barry Warsaw
Status: Merged
Merged at revision: 221
Proposed branch: lp://qastaging/~barry/dialer-app/py3autopilot
Merge into: lp://qastaging/dialer-app
Diff against target: 223 lines (+21/-25)
10 files modified
debian/control (+4/-2)
debian/rules (+4/-1)
tests/CMakeLists.txt (+1/-1)
tests/autopilot/dialer_app/emulators.py (+1/-3)
tests/autopilot/dialer_app/fixture_setup.py (+1/-1)
tests/autopilot/dialer_app/helpers.py (+1/-2)
tests/autopilot/dialer_app/tests/__init__.py (+1/-1)
tests/autopilot/dialer_app/tests/test_calls.py (+5/-4)
tests/autopilot/dialer_app/tests/test_dialer.py (+0/-5)
tests/autopilot/dialer_app/tests/test_logs.py (+3/-5)
To merge this branch: bzr merge lp://qastaging/~barry/dialer-app/py3autopilot
Reviewer Review Type Date Requested Status
Leo Arias (community) Disapprove
PS Jenkins bot continuous-integration Needs Fixing
Dimitri John Ledkov Pending
Review via email: mp+229095@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2014-07-30.

Commit message

Port tests to Python 3

Description of the change

Port to python3-autopilot

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote : Posted in a previous version of this proposal

8 - python:any,
9 + python3-all,

Should be "python3:any", or "python3-all:any".

Should call dh_python3 helper.

Should install tests in python3 path.

review: Needs Fixing
Revision history for this message
Dimitri John Ledkov (xnox) wrote : Posted in a previous version of this proposal
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

Now the tests are failing with ImportError: No module named 'exceptions'

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

I tested this on my utopic and it works without issues. I don't understand what can be failing now on Jenkins.

Revision history for this message
Barry Warsaw (barry) wrote : Posted in a previous version of this proposal

On May 30, 2014, at 09:34 AM, Leo Arias wrote:

>I tested this on my utopic and it works without issues. I don't understand
>what can be failing now on Jenkins.

IME, that's not an uncommon situation unfortunately. ;)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

It's likely that the previous error while installing ofono was fixed by Francis. But this now needs a merge with trunk. I'm sorry Barry, but can you give it another try?

Revision history for this message
Barry Warsaw (barry) wrote : Posted in a previous version of this proposal

On Jun 20, 2014, at 12:07 AM, Leo Arias wrote:

>It's likely that the previous error while installing ofono was fixed by
>Francis. But this now needs a merge with trunk. I'm sorry Barry, but can you
>give it another try?

Trunk merged and pushed.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

Ok, one single failure. I'll dig into this. Thanks Barry.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Brendan Donegan (brendan-donegan) wrote : Posted in a previous version of this proposal

I can reproduce those failures, plus some other ones.

Revision history for this message
Barry Warsaw (barry) wrote : Posted in a previous version of this proposal

On Jul 22, 2014, at 10:55 AM, Brendan Donegan wrote:

>I can reproduce those failures, plus some other ones.

I just merged trunk for both this and address-book-app, and pushed branch
updates. Let's see what happens.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:144
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~barry/dialer-app/py3autopilot/+merge/228892/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/dialer-app-ci/331/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-amd64-ci/102
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/101
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/101/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/102
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2743
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2184
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2842
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3986
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3986/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10700
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1811
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2443
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2443/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/331/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

This still needs to be merged with the prerequisite. Or wait for it to land, that should happen soon.

Revision history for this message
Barry Warsaw (barry) wrote : Posted in a previous version of this proposal

On Jul 31, 2014, at 05:19 AM, Leo Arias wrote:

>This still needs to be merged with the prerequisite. Or wait for it to land,
>that should happen soon.

Sorry, I forgot to merge the prereq, although I did set it in the mp. I've
now merged trunk and resubmitted MP without the prereq branch (which has
landed on the trunk).

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:145
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~barry/dialer-app/py3autopilot/+merge/229095/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/dialer-app-ci/338/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-amd64-ci/109
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/108
        deb: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-armhf-ci/108/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/dialer-app-utopic-i386-ci/109
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2855
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/2270/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2928
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4098
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4098/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10798
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/1876/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2533
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/2533/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dialer-app-ci/338/rebuild

review: Needs Fixing (continuous-integration)
146. By Barry Warsaw

trunk merge

147. By Barry Warsaw

Simplify some super() calls.

148. By Barry Warsaw

Try to fix failing test.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
149. By Barry Warsaw

Revert that last change.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
150. By Barry Warsaw

trunk merge

151. By Barry Warsaw

On the autopilot test, sleep before hanging up.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

Sorry about that Failed run up there ^. I clicked the wrong thing on jenkins.

Revision history for this message
Leo Arias (elopio) wrote :

The results from http://jenkins.qa.ubuntu.com/job/dialer-app-ci/354/ are the right ones.
They fail on mako, just as it happens on the dashboard. So it's not related to this branch. I'm flashing my phone to try to reproduce the error.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
152. By Barry Warsaw

trunk merge

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

While Barry is on holidays, I branched this and added the last couple of fixes. That one is ready to land:
https://code.launchpad.net/~canonical-platform-qa/dialer-app/py3autopilot-debug2/+merge/230322

Thanks Barry.

review: Disapprove

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches