Ubuntu
python-defaults package

Merge lp://qastaging/~barry/ubuntu/maverick/python-defaults/613674-pycompile into lp://qastaging/ubuntu/maverick/python-defaults

  1. Maverick (10.10)
  2. 613674-pycompile
  3. Merge into maverick
Proposed by Barry Warsaw
Status: Merged
Merge reported by: Barry Warsaw
Merged at revision: not available
Proposed branch: lp://qastaging/~barry/ubuntu/maverick/python-defaults/613674-pycompile
Merge into: lp://qastaging/ubuntu/maverick/python-defaults
Diff against target: 12 lines (+1/-1)
1 file modified
pycompile (+1/-1)
To merge this branch: bzr merge lp://qastaging/~barry/ubuntu/maverick/python-defaults/613674-pycompile
Reviewer Review Type Date Requested Status
Matthias Klose Pending
Ubuntu branches Pending
Review via email: mp+31804@code.qastaging.launchpad.net

Description of the change

Uses process.terminate() instead of process.communicate() to avoid system freeze.

To post a comment you must log in.
Revision history for this message
James Westby (james-w) wrote :

On Wed, 04 Aug 2010 23:52:43 -0000, Barry Warsaw <email address hidden> wrote:
> Barry Warsaw has proposed merging lp:~barry/ubuntu/maverick/python-defaults/613674-pycompile into lp:ubuntu/python-defaults.
>
> Requested reviews:
> Matthias Klose (doko)
> Ubuntu branches (ubuntu-branches)
> Related bugs:
> #613675 pycompile hangs when there is more than one python installed
> https://bugs.launchpad.net/bugs/613675
>
>
> Uses process.terminate() instead of process.communicate() to avoid system freeze.

Does it matter that this is 2.6 and newer?

Do the subprocess have stdin=subprocess.PIPE?

Thanks,

James

Revision history for this message
Barry Warsaw (barry) wrote :

On Aug 04, 2010, at 09:32 PM, James Westby wrote:

>On Wed, 04 Aug 2010 23:52:43 -0000, Barry Warsaw <email address hidden>
>wrote:
>> Barry Warsaw has proposed merging
>> lp:~barry/ubuntu/maverick/python-defaults/613674-pycompile into
>> lp:ubuntu/python-defaults.
>>
>> Requested reviews:
>> Matthias Klose (doko)
>> Ubuntu branches (ubuntu-branches)
>> Related bugs:
>> #613675 pycompile hangs when there is more than one python
>> installed https://bugs.launchpad.net/bugs/613675
>>
>>
>> Uses process.terminate() instead of process.communicate() to avoid
>> system freeze.
>
>Does it matter that this is 2.6 and newer?

I think that's fine, though I'll defer to Matthias. Debian and Ubuntu only
care about Python 2.6+ now I think, though it's possible Debian still has to
support Python 2.5.

>Do the subprocess have stdin=subprocess.PIPE?

Yep.
-Barry

lp://qastaging/~barry/ubuntu/maverick/python-defaults/613674-pycompile updated
57. By Barry Warsaw

We can't use .terminate() since Debian still needs to support Python 2.5 which
doesn't have that method. It didn't seem right anyway. Setting
close_fds=True seems to do the trick and is not an unreasonable workaround.

Revision history for this message
Sebastien Bacher (seb128) wrote :

the bug has been closed, is that request still valid or should it be closed as well?

Revision history for this message
Barry Warsaw (barry) wrote :

Hi Sebastien. This has now been merged upstream.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: