Software Updater

Merge lp://qastaging/~barry/update-manager/lp1295392 into lp://qastaging/update-manager

lp1295392
Merge into main

Proposed by Barry Warsaw on 2014-03-20

Status:	Merged
Merged at revision:	2674
Proposed branch:	lp://qastaging/~barry/update-manager/lp1295392
Merge into:	lp://qastaging/update-manager
Diff against target:	23 lines (+4/-2) 1 file modified tests/test_update_list.py (+4/-2)
To merge this branch:	bzr merge lp://qastaging/~barry/update-manager/lp1295392
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Michael Vogt (community)		2014-03-20	Approve on 2014-04-01
Review via email: mp+212065@code.qastaging.launchpad.net

Revision history for this message

Sebastien Bacher (seb128) wrote on 2014-03-31:

The bug pointed has been fixed by that commit it seems
http://bazaar.launchpad.net/~ubuntu-core-dev/update-manager/main/revision/2672

Not sure if the change proposed there still make sense in that context ... Michael?

Revision history for this message

Barry Warsaw (barry) wrote on 2014-03-31:

It's probably still relevant, but I'll let mvo decide.

Revision history for this message

Michael Vogt (mvo) wrote on 2014-04-01:

Thanks Barry and Seb - I think the mock_randint change is good to have, I tweaked the test a bit to include on ignored_src and one install_src (before one of the sets was always empty).

review: Approve