lp://qastaging/~barryprice/charm-haproxy/linting-fixes

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/charm-haproxy at revision 125

Nick Moffitt (community): Needs Fixing on 2019-03-21

Diff: 197 lines (+23/-19)

5 files modified

.bzrignore (+1/-0)
Makefile (+1/-1)
hooks/hooks.py (+8/-5)
hooks/tests/test_config_changed_hooks.py (+5/-5)
hooks/tests/test_helpers.py (+8/-8)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

125. By Barry Price on 2019-03-21

Linting fixes, bzr ignore .venv dir

124. By Barry Price on 2019-03-21

Actually append the port to the list 🙄

123. By Barry Price on 2019-03-21

Fix install_hook unit test where packages may be filtered if already installed, remove empty __init__.py

122. By Barry Price on 2019-03-21

Fix coverage tests for config-changed by mocking hookenv.opened_ports()

121. By Barry Price on 2019-03-20

Compare new service ports against currently-opened ports instead of potentially-opened ports

Reviewed-on: https://code.launchpad.net/~barryprice/charm-haproxy/trunk/+merge/364720
Reviewed-by: Tom Haddon <email address hidden>

120. By Barry Price on 2019-03-19

Drop cm.py (which was pulling the obsolete LP Bazaar repo), use curl to pull in the latest charm-helpers sync script from github

Reviewed-on: https://code.launchpad.net/~barryprice/charm-haproxy/charmhelpers-git/+merge/364737
Reviewed-by: Stuart Bishop <email address hidden>

119. By Billy Olsen on 2019-03-18

Convert the subjectAltName into an IP Address for comparison.

Convert the subjectAltName component to an IP Address and then
cast to a string prior to comparing to adding it to the set of
IP addresses found in the self-signed certificate properies.
Casting it directly to a str doesn't work as it is an OctetString
type and presents the data as the raw bytes of an IP address.

The ipaddress library already has the capability of parsing the
octet string bytes into an IP address and handles both IPv4 and
IPv6 forms.

Closes-Bug: #1818761

Reviewed-on: https://code.launchpad.net/~billy-olsen/charm-haproxy/octet-string/+merge/364017
Reviewed-by: Edward Hope-Morley <email address hidden>
Reviewed-by: Stuart Bishop <email address hidden>
Reviewed-by: Chris Johnston <email address hidden>
Reviewed-by: Felipe Reyes <email address hidden>

118. By Simon Davy on 2019-02-12

Add an empty default for service_options.

This means that you can deploy haproxy with a services config that specifies service_host/service_port, but not options. This allows the relation to specify options, but the haproxy services config can specify ports.

Reviewed-on: https://code.launchpad.net/~bloodearnest/charm-haproxy/make-service-options-optional/+merge/321567
Reviewed-by: Nick Moffitt <email address hidden>
Reviewed-by: Adam Collard <email address hidden>

117. By Simon Poirier on 2018-07-11

use IP in self-signed subjectAltName

Reviewed-on: https://code.launchpad.net/~simpoir/charm-haproxy/ip-selfsigned/+merge/349258
Reviewed-by: Nick Moffitt <email address hidden>

116. By Junien Fridrick on 2018-06-18

allow detection of IPv6 addresses in "bind" stanzas