juju-deployer

Merge lp://qastaging/~barryprice/juju-deployer/lp1893162 into lp://qastaging/juju-deployer

lp1893162
Merge into trunk

Proposed by Barry Price on 2020-11-02

Status:

Merged

Approved by:

Tom Haddon on 2021-02-05

Approved revision:

227

Merged at revision:

222

Proposed branch:

lp://qastaging/~barryprice/juju-deployer/lp1893162

Merge into:

lp://qastaging/juju-deployer

Diff against target:

94 lines (+59/-0)

4 files modified

Makefile (+9/-0)
README (+11/-0)
suggest_install_deps.sh (+13/-0)
suggest_install_test_deps.sh (+26/-0)

To merge this branch:

bzr merge lp://qastaging/~barryprice/juju-deployer/lp1893162

Low

Fix Committed

Link a bug report

Reviewer	Date Requested	Status
Tom Haddon	2020-11-02	Approve on 2021-02-05
Canonical IS Reviewers	2020-11-02	Pending
Review via email: mp+393172@code.qastaging.launchpad.net

Commit message

Document dependencies (LP:1893162)

lp://qastaging/~barryprice/juju-deployer/lp1893162 updated on 2020-11-02

223. By Barry Price on 2020-11-02: Clean up

Revision history for this message

🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote on 2020-11-02:

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

lp://qastaging/~barryprice/juju-deployer/lp1893162 updated on 2020-11-03

224. By Barry Price on 2020-11-02: Move deps logic to separate shell scripts
225. By Barry Price on 2020-11-03: Bugfix
226. By Barry Price on 2020-11-03: shellcheck

Revision history for this message

Tom Haddon (mthaddon) wrote on 2020-11-05:

I think it'd be worth changing the names of the scripts to reflect that they prompt you to install dependencies (which I think is the right thing to do - I don't think we should actually be installing dependencies here). Currently ./install_deps.sh to me suggests they're installing things, so maybe ./suggest_install_deps.sh and ./suggest_install_test_deps.sh or something like that?

lp://qastaging/~barryprice/juju-deployer/lp1893162 updated on 2021-02-05