Merge lp://qastaging/~bcbc/wubi/lp-862003-plus3more into lp://qastaging/wubi

Proposed by bcbc
Status: Merged
Merged at revision: 259
Proposed branch: lp://qastaging/~bcbc/wubi/lp-862003-plus3more
Merge into: lp://qastaging/wubi
Diff against target: 98 lines (+30/-9)
3 files modified
debian/changelog (+10/-0)
src/wubi/backends/common/backend.py (+2/-1)
src/wubi/backends/win32/backend.py (+18/-8)
To merge this branch: bzr merge lp://qastaging/~bcbc/wubi/lp-862003-plus3more
Reviewer Review Type Date Requested Status
Ubuntu Installer Team Pending
Review via email: mp+94507@code.qastaging.launchpad.net

Description of the change

* Correct NameError exceptions on missing attributes
  when running CD boot helper or a CD is rejected (LP: #876154).

I tested this by installing from a USB with a partition > 900,000,000 bytes so that it fails the size check. This results in a NameError on self.info.cd_path. I had to tweak some code to test this, because it ignored the size failure because it was an alpha release.
I tested the NameError on self.info.iso_path by using the "help me to boot' option from the CD boot menu (from the same USB stick). I got the NameError on rev 256 but not with my change.
------

* Ignore Permission denied when copying wubildr everywhere
  (LP: #862003)

I tested my fix by running it on Windows 7 with the Microsoft office Q: drive. I got the Permission Denied error with rev 256, but not with my version. It installed and booted successfully.
---------
* Don't fail if Windows' startup folder is missing or mis-
  configured (LP: #910948)

I have regression tested this on my Windows 7 - my fix doesn't cause any issues. I tried to rename my Startup folder but Win7 was overriding my attempts and I don't feel like breaking it just yet. The code change is pretty straightforward.
---------

* If bcdedit fails when uninstalling, it shouldn't be fatal
  (LP: #925779)

Not tested yet, but the code change is pretty straightforward.
----------------------------

To post a comment you must log in.
Revision history for this message
bcbc (bcbc) wrote :

The fix I described as "Correct NameError exceptions on missing attributes when running CD boot helper or a CD is rejected (LP: #876154)." also fixes bug 891577.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: