Landscape Client

Merge lp://qastaging/~benji/landscape-client/demockerify-test_packagemonitor.py into lp://qastaging/~landscape/landscape-client/trunk

  1. demockerify-test_packagemonitor.py
  2. Merge into trunk
Proposed by Benji York
Status: Merged
Approved by: Benji York
Approved revision: 857
Merged at revision: 890
Proposed branch: lp://qastaging/~benji/landscape-client/demockerify-test_packagemonitor.py
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 247 lines (+63/-70)
1 file modified
landscape/monitor/tests/test_packagemonitor.py (+63/-70)
To merge this branch: bzr merge lp://qastaging/~benji/landscape-client/demockerify-test_packagemonitor.py
Reviewer Review Type Date Requested Status
Chad Smith Approve
🤖 Landscape Builder test results Approve
Adam Collard (community) Approve
Review via email: mp+297633@code.qastaging.launchpad.net

Commit message

more mocker mayhem

Description of the change

more mocker mayhem

Testing instructions:

trial -j4 landscape

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 855
Branch: lp:~benji/landscape-client/demockerify-test_packagemonitor.py
Jenkins: https://ci.lscape.net/job/latch-test/5089/

review: Approve (test results)
Revision history for this message
Adam Collard (adam-collard) :
review: Needs Fixing
Revision history for this message
Benji York (benji) wrote :

Thanks for the good review. I've responded to each comment inline.

Revision history for this message
Chad Smith (chad.smith) wrote :

minor nit.

lp://qastaging/~benji/landscape-client/demockerify-test_packagemonitor.py updated
856. By Benji York

review fixes

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
Adam Collard (adam-collard) wrote :

+1, looks good!

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 856
Branch: lp:~benji/landscape-client/demockerify-test_packagemonitor.py
Jenkins: https://ci.lscape.net/job/latch-test/5096/

review: Approve (test results)
Revision history for this message
Chad Smith (chad.smith) :
review: Approve
Revision history for this message
Bogdana Vereha (bogdana) wrote :

Added a minor comment.

Revision history for this message
Benji York (benji) wrote :

Thanks for the note, Bogdana.

Revision history for this message
Benji York (benji) wrote :

Thanks for the good review Chad. I've fixed the things you highlighted.

lp://qastaging/~benji/landscape-client/demockerify-test_packagemonitor.py updated
857. By Benji York

review fixes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: