Landscape Client

Merge lp://qastaging/~benji/landscape-client/mocker-purge-test_reporter.py into lp://qastaging/~landscape/landscape-client/trunk

  1. mocker-purge-test_reporter.py
  2. Merge into trunk
Proposed by Benji York
Status: Merged
Approved by: Benji York
Approved revision: 901
Merged at revision: 902
Proposed branch: lp://qastaging/~benji/landscape-client/mocker-purge-test_reporter.py
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 138 lines (+37/-35)
1 file modified
landscape/package/tests/test_reporter.py (+37/-35)
To merge this branch: bzr merge lp://qastaging/~benji/landscape-client/mocker-purge-test_reporter.py
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Approve
Bogdana Vereha (community) Approve
Simon Poirier (community) Approve
Review via email: mp+297670@code.qastaging.launchpad.net

Commit message

maligned mocker mitigation

Description of the change

maligned mocker mitigation

Testing instructions:

trial -j 3212 landscape

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 899
Branch: lp:~benji/landscape-client/mocker-purge-test_reporter.py
Jenkins: https://ci.lscape.net/job/latch-test/5106/

review: Approve (test results)
Revision history for this message
Simon Poirier (simpoir) wrote :

+1
Nitpick : wouldn't it be safer and closer to mocker's behaviour to self.addCleanup(x_patcher.stop) after start()
instead of at the theoretical end of a test.

review: Approve
Revision history for this message
Benji York (benji) wrote :

> +1
> Nitpick : wouldn't it be safer and closer to mocker's behaviour to
> self.addCleanup(x_patcher.stop) after start()
> instead of at the theoretical end of a test.

+1

Done.

Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
Bogdana Vereha (bogdana) wrote :

+1

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 900
Branch: lp:~benji/landscape-client/mocker-purge-test_reporter.py
Jenkins: https://ci.lscape.net/job/latch-test/5107/

review: Approve (test results)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

No approved revision specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: