Merge lp://qastaging/~benji/launchpad/bug-607154 into lp://qastaging/launchpad
| Status: | Merged |
|---|---|
| Approved by: | Robert Collins |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 11249 |
| Proposed branch: | lp://qastaging/~benji/launchpad/bug-607154 |
| Merge into: | lp://qastaging/launchpad |
| Diff against target: |
226 lines (+114/-25) 3 files modified
lib/canonical/launchpad/webapp/publication.py (+31/-24) lib/canonical/launchpad/webapp/servers.py (+13/-1) lib/canonical/launchpad/webapp/tests/test_pageid.py (+70/-0) |
| To merge this branch: | bzr merge lp://qastaging/~benji/launchpad/bug-607154 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Robert Collins (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Calls to the web service generate page IDs that aren't as helpful as
they could be because the named operation is not included and is often a
critical differentiator (see bug 607154).
In this branch the named operation (if any) is appended to the page ID
(after a colon).
This was done by refactoring the page ID generation code out of
lib/canonical/
and into its own method (LaunchpadBrows
and then overriding constructPageID in WebServicePubli
new behavior.
The behavior and approach were discussed with Gary and Leonard.
To run the tests for the new behavior run
bin/test -t test_pageid
I also cleaned up quite a bit of lint. Most of it was whitespace or
silencing false positives. I could not force this lint to be silent
though (suggestions welcome):
./lib/canonical
193: E231 missing whitespace after ','
| Benji York (benji) wrote | # |
+
+
+def test_suite():
+ return unittest.
Thats noise - its not needed - please remove.