Merge lp://qastaging/~berolinux/linaro-image-tools/remove-superfluous-dependency into lp://qastaging/linaro-image-tools/11.11

Proposed by Bernhard Rosenkraenzer
Status: Merged
Approved by: Milo Casagrande
Approved revision: 522
Merged at revision: 528
Proposed branch: lp://qastaging/~berolinux/linaro-image-tools/remove-superfluous-dependency
Merge into: lp://qastaging/linaro-image-tools/11.11
Diff against target: 20 lines (+1/-3)
1 file modified
linaro-android-media-create (+1/-3)
To merge this branch: bzr merge lp://qastaging/~berolinux/linaro-image-tools/remove-superfluous-dependency
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
Review via email: mp+107924@code.qastaging.launchpad.net

Description of the change

linaro-android-media-create refuses to run if it can't find qemu-arm-static, but qemu-arm-static is needed only to install hwpacks that aren't used in Android anyway

To post a comment you must log in.
Revision history for this message
Milo Casagrande (milo) wrote :

Hi,

proposed merge looks good to me.
pep8 complains about too many blank lines after the import statement you modified:

linaro-android-media-create:48:1: E303 too many blank lines (3)

Might not be related to your change though. Can you please fix that little small thing too?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches