Offspring

Merge lp://qastaging/~bigkevmcd/offspring/logging-setup-difference into lp://qastaging/offspring

  1. logging-setup-difference
  2. Merge into trunk
Proposed by Kevin McDermott
Status: Merged
Approved by: Timothy R. Chavez
Approved revision: 131
Merged at revision: 137
Proposed branch: lp://qastaging/~bigkevmcd/offspring/logging-setup-difference
Merge into: lp://qastaging/offspring
Diff against target: 210 lines (+64/-34)
3 files modified
lib/offspring/slave/slave.py (+6/-5)
lib/offspring/slave/tests/helpers.py (+0/-1)
lib/offspring/slave/tests/test_slave.py (+58/-28)
To merge this branch: bzr merge lp://qastaging/~bigkevmcd/offspring/logging-setup-difference
Reviewer Review Type Date Requested Status
Timothy R. Chavez Approve
Review via email: mp+101495@code.qastaging.launchpad.net

Description of the change

This changes the slave to setup logging in the same way as the master.

To post a comment you must log in.
Revision history for this message
Timothy R. Chavez (timrchavez) wrote :

Seems like this is two things wrapped into one... 1 is a change to use get_slave() in all tests and the other is a change to how logging works?

Revision history for this message
Kevin McDermott (bigkevmcd) wrote :

> Seems like this is two things wrapped into one... 1 is a change to use
> get_slave() in all tests and the other is a change to how logging works?

get_slave() is just a refactoring, as we're creating the same slave everywhere...

Revision history for this message
Timothy R. Chavez (timrchavez) wrote :

Right, so shouldn't the refactor be its own change / MP that the fix for Bug #978627 builds on top of?

lp://qastaging/~bigkevmcd/offspring/logging-setup-difference updated
131. By Kevin McDermott

Merge trunk.

Revision history for this message
Timothy R. Chavez (timrchavez) wrote :

Code looks good. I patched offspring and instantiated my own LexbuilderSlave object in a Django shell to verify that logging was being setup (based on config option) and working. I then ran all the slave tests to verify that they all passed.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches