Offspring

Merge lp://qastaging/~bigkevmcd/offspring/offspring-master-armhf into lp://qastaging/offspring

offspring-master-armhf
Merge into trunk

Proposed by Kevin McDermott on 2012-03-01

Status:

Merged

Approved by:

Cody A.W. Somerville on 2012-03-01

Approved revision:

123

Merged at revision:

122

Proposed branch:

lp://qastaging/~bigkevmcd/offspring/offspring-master-armhf

Merge into:

lp://qastaging/offspring

Diff against target:

71 lines (+37/-2)

2 files modified

lib/offspring/master/master.py (+1/-0)
lib/offspring/master/tests/test_master.py (+36/-2)

To merge this branch:

bzr merge lp://qastaging/~bigkevmcd/offspring/offspring-master-armhf

Related bugs:

Bug #892240: support armhf architecture

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Cody A.W. Somerville		2012-03-01	Approve on 2012-03-01
Review via email: mp+95409@code.qastaging.launchpad.net

Description of the change

This adds support for building armhf projects on armv7l builders.

Revision history for this message

Cody A.W. Somerville (cody-somerville) on 2012-03-01:

review: Approve

Revision history for this message

Cody A.W. Somerville (cody-somerville) wrote on 2012-03-01:

Food for future thought: Is there a way we can more generically test the arch to machine_type relation in dispatch code? Having a test per arch seems of dubious value.

Revision history for this message

Kevin McDermott (bigkevmcd) wrote on 2012-03-02:

Yip...we could split the project.arch -> builder arch lookup out into something like get_builder_arches_for_project, and then test that we can translate for the various project.arch values that they get translated to something appropriate.

It's called refactoring ;-)