Merge lp://qastaging/~bilalakhtar/unity/fix-unity-crash-on-hidden-quicklistitem into lp://qastaging/unity

Proposed by Bilal Akhtar
Status: Merged
Merged at revision: 1188
Proposed branch: lp://qastaging/~bilalakhtar/unity/fix-unity-crash-on-hidden-quicklistitem
Merge into: lp://qastaging/unity
Diff against target: 15 lines (+5/-0)
1 file modified
src/LauncherIcon.cpp (+5/-0)
To merge this branch: bzr merge lp://qastaging/~bilalakhtar/unity/fix-unity-crash-on-hidden-quicklistitem
Reviewer Review Type Date Requested Status
Neil J. Patel (community) Approve
Review via email: mp+61067@code.qastaging.launchpad.net

Description of the change

This branch makes Unity ignore a Dbusmenu MenuItem if its PROP_VISIBLE isn't true. This fixes the crash bug #759174 which would make Unity crash if there was a Dbusmenu MenuItem which doesn't have its visible property set to true.

To post a comment you must log in.
Revision history for this message
Neil J. Patel (njpatel) wrote :

should be

// Skip this item, it's invisible right now
if (!prop_visible)
  continue;

Will update and commit to trunk and unity/3.0

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.