Charm Helpers

Merge lp://qastaging/~billy-olsen/charm-helpers/better-address-endpoint-overrides into lp://qastaging/charm-helpers

better-address-endpoint-overrides
Merge into devel

Proposed by Billy Olsen on 2015-06-03

Status:

Merged

Merged at revision:

383

Proposed branch:

lp://qastaging/~billy-olsen/charm-helpers/better-address-endpoint-overrides

Merge into:

lp://qastaging/charm-helpers

Diff against target:

224 lines (+75/-73)

2 files modified

charmhelpers/contrib/openstack/ip.py (+49/-44)
tests/contrib/openstack/test_ip.py (+26/-29)

To merge this branch:

bzr merge lp://qastaging/~billy-olsen/charm-helpers/better-address-endpoint-overrides

Medium

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Jorge Niedbalski (community)	2015-06-03	Approve on 2015-06-04
Felipe Reyes	2015-06-03	Pending
charmers	2015-06-03	Pending
Edward Hope-Morley	2015-06-03	Pending
Review via email: mp+261000@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-05-29.

lp://qastaging/~billy-olsen/charm-helpers/better-address-endpoint-overrides updated on 2015-06-04

387. By Billy Olsen on 2015-06-04: Add templating to the os-public-hostname override per jjo's bug comment.

Revision history for this message

Jorge Niedbalski (niedbalski) wrote on 2015-06-04:

Thanks billy for the proposal.

I think this approach is much simpler, +1 from my side.

review: Approve

Revision history for this message

Jorge Niedbalski (niedbalski) wrote on 2015-06-04:

The jinja package requires to be installed on the system, in case of partial importing of this helper, this will not work. Please see: charmhelpers.core.templating. I

This could be replaced by a standard string replacement. see pydoc format.

Thanks billy.

review: Needs Fixing

lp://qastaging/~billy-olsen/charm-helpers/better-address-endpoint-overrides updated on 2015-06-04

388. By Billy Olsen on 2015-06-04: Per niedbalski's review remove jinja2 dependency and use simple string
formatting. Additionally break out the override check into its own
function.