Charm Helpers

Merge lp://qastaging/~billy-olsen/charm-helpers/ceph-pg-calc into lp://qastaging/charm-helpers

  1. ceph-pg-calc
  2. Merge into devel
Proposed by Billy Olsen
Status: Merged
Merged at revision: 606
Proposed branch: lp://qastaging/~billy-olsen/charm-helpers/ceph-pg-calc
Merge into: lp://qastaging/charm-helpers
Diff against target: 429 lines (+209/-59)
2 files modified
charmhelpers/contrib/storage/linux/ceph.py (+129/-41)
tests/contrib/storage/test_linux_ceph.py (+80/-18)
To merge this branch: bzr merge lp://qastaging/~billy-olsen/charm-helpers/ceph-pg-calc
Reviewer Review Type Date Requested Status
Jorge Niedbalski (community) Approve
Chris Holcombe (community) Approve
Edward Hope-Morley Pending
Review via email: mp+298557@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Chris Holcombe (xfactor973) wrote :

This looks good to me and well thought out!

review: Approve
lp://qastaging/~billy-olsen/charm-helpers/ceph-pg-calc updated
588. By Billy Olsen

Add check to cap the number of placement groups that will be created.

589. By Billy Olsen

Merge in latest from trunk

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

The code is pretty clear and aligned with the documentation expressed on http://ceph.com/pgcalc/.

I've made some minor typo corrections, all the rest looks good to me.

review: Needs Fixing
Revision history for this message
Billy Olsen (billy-olsen) wrote :

Thanks Jorge!

Corrections are being made

lp://qastaging/~billy-olsen/charm-helpers/ceph-pg-calc updated
590. By Billy Olsen

Fix comments per code review feedback.

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches