Juju Charms Collection
mongodb package

Merge lp://qastaging/~billy-olsen/charms/trusty/mongodb/lp1513094 into lp://qastaging/charms/trusty/mongodb

  1. Trusty Tahr (14.04)
  2. lp1513094
  3. Merge into trunk
Proposed by Billy Olsen
Status: Merged
Merged at revision: 89
Proposed branch: lp://qastaging/~billy-olsen/charms/trusty/mongodb/lp1513094
Merge into: lp://qastaging/charms/trusty/mongodb
Diff against target: 319 lines (+83/-91)
5 files modified
hooks/hooks.py (+60/-86)
tests/01_deploy_single.py (+1/-1)
tests/02_deploy_shard_test.py (+2/-2)
tests/03_deploy_replicaset.py (+2/-2)
unit_tests/test_hooks.py (+18/-0)
To merge this branch: bzr merge lp://qastaging/~billy-olsen/charms/trusty/mongodb/lp1513094
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Needs Information
Andrew McLeod (community) Needs Fixing
Review Queue (community) automated testing Needs Fixing
Review via email: mp+294565@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #2558 mongodb for billy-olsen mp294565
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/2558/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #1989 mongodb for billy-olsen mp294565
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/1989/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #743 mongodb for billy-olsen mp294565
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/16381918/
Build: http://10.245.162.36:8080/job/charm_amulet_test/743/

Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-lxc/4174/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws:8080/job/charm-bundle-test-aws/4187/

review: Needs Fixing (automated testing)
Revision history for this message
Andrew McLeod (admcleod) wrote :

Hi there Billy,

This is failing with the following. I wonder if this is just a matter of naming in the tests?

bundletester -vFt tests/ -l DEBUG -e sneerAWS --no-destroy

With the following 2 errors:

Failed to find running MongoDB on host config-sentry
Failed to find running MongoDB on host mongodb1-sentry

review: Needs Fixing
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #6 mongodb for billy-olsen mp294565
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
Makefile:35: recipe for target 'test' failed
ERROR:root:Make target returned non-zero.

Full unit test output: http://paste.ubuntu.com/23110021/
Build: http://10.245.162.208:8080/job/charm_unit_test/6/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Can we please refactor the unit test and bundletester test environments here to build a virtualenv, use tox, ostestr, etc., a la OpenStack Charms? Extra credit for that! ;-)

Bottom line is the test suite won't pass anymore in OSCI, as we're getting very strict with tests that try to bring in arbitrary debs.

The litmus test is this:

A fresh Xenial instance. Juju, juju-deployer, charm-tools debs installed. Everything else in a venv. Tests should exec and pass.

Thank you!

review: Needs Information
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #17 mongodb for billy-olsen mp294565
    LINT OK: passed

Build: http://10.245.162.208:8080/job/charm_lint_check/17/

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches