Merge lp://qastaging/~billy-olsen/ubuntu-openstack-ci/recheck into lp://qastaging/ubuntu-openstack-ci

Proposed by Billy Olsen
Status: Rejected
Rejected by: Ryan Beisner
Proposed branch: lp://qastaging/~billy-olsen/ubuntu-openstack-ci/recheck
Merge into: lp://qastaging/ubuntu-openstack-ci
Diff against target: 175 lines (+109/-29)
2 files modified
common/osci_utils.py (+11/-0)
tools/scan_merge_props.py (+98/-29)
To merge this branch: bzr merge lp://qastaging/~billy-olsen/ubuntu-openstack-ci/recheck
Reviewer Review Type Date Requested Status
Ryan Beisner (community) Needs Resubmitting
Review via email: mp+272321@code.qastaging.launchpad.net

Description of the change

Adds logic to the scan_merge_props.py to allow for a #recheck comment to trigger a re-run of the unit, lint, and amulet testing suite.

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #10709 lp:ubuntu-openstack-ci for billy-olsen mp272321
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/12548574/
Build: http://10.245.162.77:8080/job/charm_lint_check/10709/

160. By Billy Olsen

Fix linting error

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #11224 lp:ubuntu-openstack-ci for billy-olsen mp272321
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/11224/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

FYI, merged into lp:~1chb1n/ubuntu-openstack-ci/recheck-validate to exercise against current repo.

Revision history for this message
Ryan Beisner (1chb1n) wrote :
review: Needs Fixing
Revision history for this message
Ryan Beisner (1chb1n) wrote :

AH I think it just needs:

mp.source_branch

Instead of src_branch.

I'll adjust that in my merge-test branch...

Revision history for this message
Ryan Beisner (1chb1n) wrote :

00:01:15.397 Traceback (most recent call last):
00:01:15.397 File "tools/scan_merge_props.py", line 414, in <module>
00:01:15.397 main()
00:01:15.397 File "tools/scan_merge_props.py", line 357, in main
00:01:15.397 changed, state = get_changed_mp_state(conf_map, opts)
00:01:15.397 File "tools/scan_merge_props.py", line 232, in get_changed_mp_state
00:01:15.397 mp_status_filter, max_tries=10)
00:01:15.397 File "tools/scan_merge_props.py", line 188, in query_branch_mp_states
00:01:15.397 last_modified_date = get_last_modified_timestamp(mp)
00:01:15.398 File "tools/scan_merge_props.py", line 100, in get_last_modified_timestamp
00:01:15.398 me = u.lpl_me()
00:01:15.398 TypeError: lpl_me() takes exactly 1 argument (0 given)

Also adjusting for this in my merge test branch ^

review: Needs Fixing
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Drumroll...

Revision history for this message
Ryan Beisner (1chb1n) wrote :

#recheck

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #1306 lp:ubuntu-openstack-ci for billy-olsen mp272321
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/1306/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #1307 lp:ubuntu-openstack-ci for billy-olsen mp272321
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/1307/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #1369 lp:ubuntu-openstack-ci for billy-olsen mp272321
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/1369/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

#recheck

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #1372 lp:ubuntu-openstack-ci for billy-olsen mp272321
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/1372/

Revision history for this message
Ryan Beisner (1chb1n) wrote :

Thank you for your work on this! I've pulled your branch into a new branch, then adjusted and tested there. We're golden. I'll be landing the following:

https://code.launchpad.net/~1chb1n/ubuntu-openstack-ci/recheck-validate/+merge/286928

review: Needs Resubmitting

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches