Unity

Merge lp://qastaging/~bitshifternz/unity/fix-for-bug-769781 into lp://qastaging/unity

fix-for-bug-769781
Merge into trunk

Proposed by Cameron Hart on 2011-04-24

Status:

Merged

Merged at revision:

1195

Proposed branch:

lp://qastaging/~bitshifternz/unity/fix-for-bug-769781

Merge into:

lp://qastaging/unity

Diff against target:

44 lines (+6/-7)

1 file modified

src/PluginAdapter.cpp (+6/-7)

To merge this branch:

bzr merge lp://qastaging/~bitshifternz/unity/fix-for-bug-769781

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Sam Spilsbury (community)		2011-04-24	Approve on 2011-05-23
Review via email: mp+58893@code.qastaging.launchpad.net

Description of the change

Checks the max size hint on the window before attempting to maximize. Also fixes memory leak.

Revision history for this message

Tim Penhey (thumper) wrote on 2011-04-25:

> Checks the max size hint on the window before attempting to maximize.

Looks reasonable to me, but I don't hold any weight just now :-)

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2011-05-23:

Approve, however being pedantic here, line 18 has weird indentation, you might want to fix that :)

Also, just for super-super-correctness, you might want to do the check against the window size minus the decorations geometry. So for that you'd have (screen_width - window->border ().left () - window->border ().right () > size_hints.max_width) ... if that makes any sense.

review: Approve

Revision history for this message

Cameron Hart (bitshifternz) wrote on 2011-05-23:

Cheers, I don't know what happened with that indentation. I'll fold in your other suggestion.

> Approve, however being pedantic here, line 18 has weird indentation, you might
> want to fix that :)
>
> Also, just for super-super-correctness, you might want to do the check against
> the window size minus the decorations geometry. So for that you'd have
> (screen_width - window->border ().left () - window->border ().right () >
> size_hints.max_width) ... if that makes any sense.