Landscape Charm

Merge lp://qastaging/~bjornt/landscape-charm/integration-tests-dense-maas into lp://qastaging/~landscape/landscape-charm/trunk

  1. integration-tests-dense-maas
  2. Merge into trunk
Proposed by Björn Tillenius
Status: Merged
Approved by: Björn Tillenius
Approved revision: 324
Merged at revision: 354
Proposed branch: lp://qastaging/~bjornt/landscape-charm/integration-tests-dense-maas
Merge into: lp://qastaging/~landscape/landscape-charm/trunk
Diff against target: 134 lines (+56/-9)
3 files modified
HACKING.md (+38/-7)
Makefile (+1/-1)
tests/helpers.py (+17/-1)
To merge this branch: bzr merge lp://qastaging/~bjornt/landscape-charm/integration-tests-dense-maas
Reviewer Review Type Date Requested Status
Francis Ginther (community) Approve
David Britton (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+298509@code.qastaging.launchpad.net

Commit message

Allow the integration tests to be run on a dense MAAS deploy,
using LXCs on machine 0.

Description of the change

Allow the integration tests to be run on a dense MAAS deploy,
using LXCs on machine 0.

Testing instructions:

See the changes to HACKING.md

Note that the integration tests are currently broken on xenial. I would
propose bootstrapping the environment manually and then run:

    DENSE_MAAS=1 LS_CHARM_SOURCE=lds-trunk-ppa zope-testrunner3 -vv \
        --path tests --tests-pattern basic --test test_bootstrap

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 323
Branch: lp:~bjornt/landscape-charm/integration-tests-dense-maas
Jenkins: https://ci.lscape.net/job/latch-test/5210/

review: Approve (test results)
Revision history for this message
David Britton (dpb) wrote :

inline comments, still reviewing.

Revision history for this message
David Britton (dpb) wrote :

testing result of the bootstrap test: https://pastebin.canonical.com/159736/

Seems good for a first pass.

Note, I had to update the postgresql version to 101 in our bundles-trunk, but once I did this, things are passing.

review: Approve
Revision history for this message
David Britton (dpb) wrote :

Also note, that many other tests fail (as Bjorn mentioned). But at least they appear to run. For instance, the first failure is this one: bug #1588415

Revision history for this message
David Britton (dpb) wrote :

And just to close this out... Full run with this new DENSE_MAAS var.

Tests with failures:
   test_pause_resume (basic.test_actions.ActionsTest)
   test_resume_fail (basic.test_actions.ActionsTest)
   test_api (basic.test_service.ServiceTest)
   test_api_endpoint (basic.test_service.ServiceTest)
   test_app (basic.test_service.ServiceTest)
   test_app_unavailable_page (basic.test_service.ServiceTest)
   test_msg (basic.test_service.ServiceTest)
   test_ping (basic.test_service.ServiceTest)
   test_upload (basic.test_service.ServiceTest)
   test_upload_non_leader_down (basic.test_ha.LandscapeHATest)
Total: 42 tests, 10 failures, 0 errors and 5 skipped in 19 minutes 35.765 seconds.

I'll dig into the rest of the failures and make sure they are bugged, but for now I would not block the landing on this.

thanks for this Bjorn!

Revision history for this message
Francis Ginther (fginther) wrote :

Also approve. Much thanks for the improved docs as well as getting this to run on dense maas.

review: Approve
Revision history for this message
Björn Tillenius (bjornt) :
Revision history for this message
Björn Tillenius (bjornt) wrote :

> And just to close this out... Full run with this new DENSE_MAAS var.
>
> Tests with failures:
> test_pause_resume (basic.test_actions.ActionsTest)
> test_resume_fail (basic.test_actions.ActionsTest)
> test_api (basic.test_service.ServiceTest)
> test_api_endpoint (basic.test_service.ServiceTest)
> test_app (basic.test_service.ServiceTest)
> test_app_unavailable_page (basic.test_service.ServiceTest)
> test_msg (basic.test_service.ServiceTest)
> test_ping (basic.test_service.ServiceTest)
> test_upload (basic.test_service.ServiceTest)
> test_upload_non_leader_down (basic.test_ha.LandscapeHATest)
> Total: 42 tests, 10 failures, 0 errors and 5 skipped in 19 minutes 35.765
> seconds.
>
> I'll dig into the rest of the failures and make sure they are bugged, but for
> now I would not block the landing on this.
>
> thanks for this Bjorn!

Note that the test_resume_fail failures will put the deployment in a bad state, so some of the other failures could be due to that.

lp://qastaging/~bjornt/landscape-charm/integration-tests-dense-maas updated
324. By Björn Tillenius

Add a note that secrets and bundles need to be generated.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches