Merge lp://qastaging/~bjornt/landscape-charm/tests-real-package into lp://qastaging/~landscape/landscape-charm/trunk
| Status: | Merged |
|---|---|
| Approved by: | Björn Tillenius |
| Approved revision: | 302 |
| Merged at revision: | 291 |
| Proposed branch: | lp://qastaging/~bjornt/landscape-charm/tests-real-package |
| Merge into: | lp://qastaging/~landscape/landscape-charm/trunk |
| Diff against target: |
303 lines (+103/-20) 9 files modified
dev/ubuntu-deps (+2/-1) lib/apt.py (+4/-3) lib/callbacks/tests/test_scripts.py (+3/-0) lib/tests/stubs.py (+50/-1) lib/tests/test_apt.py (+34/-15) lib/tests/test_migrate_schema.py (+1/-0) lib/tests/test_pause.py (+3/-0) lib/tests/test_resume.py (+3/-0) lib/tests/test_services.py (+3/-0) |
| To merge this branch: | bzr merge lp://qastaging/~bjornt/landscape-charm/tests-real-package |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| 🤖 Landscape Builder | test results | Approve | |
| Fernando Correa Neto (community) | Approve | ||
| Free Ekanayaka (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Change the package building tests to use real subprocess calls as much
as possible.
Using real calls is slower, but it give more confidence that things
work, as opposed to checking that a long list of commands were issued.
For example, this revealed a bug where the source tarball got
overwritten in some cases.
Description of the change
Change the package building tests to use real subprocess calls as much
as possible.
Using real calls is slower, but it give more confidence that things
work, as opposed to checking that a long list of commands were issued.
For example, this revealed a bug where the source tarball got
overwritten in some cases.
The main driver for this change is to make SubprocessStub being able to
be a bit more real and provide functionality for providing custom output
and fail scenarios. I made it so that you have to explicitly say which
executables that should be fake, since we should use that functionality
as little as possible.
Subprocess.
the next branch. I added it here to show how final results in one place.
| 🤖 Landscape Builder (landscape-builder) wrote | # |
| Björn Tillenius (bjornt) wrote | # |
| 🤖 Landscape Builder (landscape-builder) wrote | # |
| 🤖 Landscape Builder (landscape-builder) wrote | # |
| 🤖 Landscape Builder (landscape-builder) wrote | # |
| 🤖 Landscape Builder (landscape-builder) wrote | # |
| 🤖 Landscape Builder (landscape-builder) wrote | # |
| 🤖 Landscape Builder (landscape-builder) wrote | # |
Command: make ci-test
Result: Fail
Revno: 296
Branch: lp:~bjornt/landscape-charm/tests-real-package
Jenkins: https:/
-------
./dev/ubuntu-deps
Reading package lists...
Building dependency tree...
Reading state information...
software-
The following package was automatically installed and is no longer required:
os-prober
Use 'apt-get autoremove' to remove it.
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
gpg: keyring `/tmp/tmpr5a4rx
gpg: keyring `/tmp/tmpr5a4rx
gpg: requesting key C8068B11 from hkp server keyserver.
gpg: /tmp/tmpr5a4rx3
gpg: key C8068B11: public key "Launchpad Ensemble PPA" imported
gpg: Total number processed: 1
gpg: imported: 1 (RSA: 1)
OK
Ign http://
Ign http://
Ign http://
Ign http://
Ign http://
Get:1 http://
Hit http://
Hit http://
Get:2 http://
Get:3 http://
Hit http://
Hit http://
Hit http://
Hit http://
Get:4 http://
Ign https:/
Ign https:/
Hit https:/
Hit https:/
Hit http://
Hit http://
Hit http://
Hit http://
Hit http://
Hit http://
Hit http://
Hit http://
Get:5 http://
Get:6 http://
Get:7 http://
Hit http://
Hit http://
Get:8 http://
Hit http://
Hit http://
Ign http://
Get:9 http://
Get:10 http://
Get:11 http://