Snapcraft

Merge lp://qastaging/~bjornt/snapcraft/setuptools into lp://qastaging/~snappy-dev/snapcraft/core

  1. setuptools
  2. Merge into core
Proposed by Björn Tillenius
Status: Merged
Approved by: Ted Gould
Approved revision: 140
Merged at revision: 158
Proposed branch: lp://qastaging/~bjornt/snapcraft/setuptools
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 94 lines (+37/-4)
4 files modified
snapcraft/plugins/python2.py (+1/-0)
snapcraft/plugins/python2_project.py (+18/-2)
snapcraft/plugins/python3.py (+1/-0)
snapcraft/plugins/python3_project.py (+17/-2)
To merge this branch: bzr merge lp://qastaging/~bjornt/snapcraft/setuptools
Reviewer Review Type Date Requested Status
Sergio Schvezov Approve
Ted Gould (community) Approve
Review via email: mp+270733@code.qastaging.launchpad.net

Commit message

Add support for setuptools based python projects.

Description of the change

Add support for setuptools based Python project.

I initially did it for Python3 only, but then I saw lp:~sergiusens/snapcraft/setuptools for Python 2. I merged in that branch and made the implementations consistent.

To post a comment you must log in.
lp://qastaging/~bjornt/snapcraft/setuptools updated
138. By Björn Tillenius

Merge trunk, resolve conflicts.

139. By Björn Tillenius

Lint.

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

this looks good.

I would prefer os.path.join instead of self.installdir + '/... though

lp://qastaging/~bjornt/snapcraft/setuptools updated
140. By Björn Tillenius

Use os.path.join()

Use single quotes instead of double quotes.

Revision history for this message
Björn Tillenius (bjornt) wrote :

On Fri, Sep 11, 2015 at 06:05:35PM -0000, Sergio Schvezov wrote:
> this looks good.
>
> I would prefer os.path.join instead of self.installdir + '/... though

Sure. I've changed it to use os.path.join()

I also changed all the strings to use single quotes, since you seem to
prefer that.

--
Björn Tillenius | https://launchpad.net/~bjornt

Revision history for this message
Ted Gould (ted) wrote :

So, what I don't love about this branch is that it pulls in setuptools everytime, even if you're not using it to build the package. All Python users are getting setup tools installed into their snap. Now, this isn't your fault. There isn't currently a way to fix this. Sergio is brainstorming a solution, but my thought is that if there's nothing easy we can take this as is with a TODO to fix that eventually.

Revision history for this message
Ted Gould (ted) wrote :

Talking on IRC about this, we don't have a solution for the packages yet, but we don't think this branch should block because of that.

review: Approve
Revision history for this message
Sergio Schvezov (sergiusens) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches