Ubuntu Accomplishments Viewer

Merge lp://qastaging/~bkerensa/ubuntu-accomplishments-viewer/0.2.1 into lp://qastaging/ubuntu-accomplishments-viewer

  1. 0.2.1
  2. Merge into accomplishments-viewer
Proposed by Benjamin Kerensa
Status: Merged
Merged at revision: 166
Proposed branch: lp://qastaging/~bkerensa/ubuntu-accomplishments-viewer/0.2.1
Merge into: lp://qastaging/ubuntu-accomplishments-viewer
Diff against target: 29 lines (+10/-2)
2 files modified
accomplishments-viewer.desktop.in (+4/-2)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp://qastaging/~bkerensa/ubuntu-accomplishments-viewer/0.2.1
Reviewer Review Type Date Requested Status
Matt Fischer Approve
Jono Bacon Needs Information
Review via email: mp+119456@code.qastaging.launchpad.net
To post a comment you must log in.
Revision history for this message
Jono Bacon (jonobacon) wrote :

Thanks for the contribution, Ben, but I am not sure what problem this fixes. Can you explain why we need to change the .desktop file?

Revision history for this message
Jono Bacon (jonobacon) :
review: Needs Information
Revision history for this message
Benjamin Kerensa (bkerensa) wrote :

To ensure it has proper entries:
https://live.gnome.org/GnomeGoals/CorrectDesktopFiles

Revision history for this message
Matt Fischer (mfisch) wrote :

Looks good. I'm leaving out the changelog as we'll just incorporate that in the 0.3 release next week.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: