Merge lp://qastaging/~bkerensa/ubuntu-release-upgrader/fix-for-1068874 into lp://qastaging/ubuntu-release-upgrader

Proposed by Benjamin Kerensa
Status: Rejected
Rejected by: Brian Murray
Proposed branch: lp://qastaging/~bkerensa/ubuntu-release-upgrader/fix-for-1068874
Merge into: lp://qastaging/ubuntu-release-upgrader
Diff against target: 43 lines (+8/-10)
2 files modified
DistUpgrade/DistUpgradeController.py (+1/-10)
debian/changelog (+7/-0)
To merge this branch: bzr merge lp://qastaging/~bkerensa/ubuntu-release-upgrader/fix-for-1068874
Reviewer Review Type Date Requested Status
Brian Murray Disapprove
Iain Lane Pending
Review via email: mp+133382@code.qastaging.launchpad.net

Description of the change

Remove Apport Enablement from DistUpgradeController.py

To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

I think you've removed a bit too much.

review: Disapprove
Revision history for this message
Benjamin Kerensa (bkerensa) wrote :

Could you elaborate?

It appears to be identical to https://code.launchpad.net/~bkerensa/ubuntu/raring/ubuntu-release-upgrader/fix-for-1068874

which I was told to just re-target

def doDistUpgrade(self):
# check if we want apport running during the upgrade
if self.config.getWithDefault("Distro","EnableApport", False):
self.enableApport()

and

def enableApport(self, fname="/etc/default/apport"):
""" enable apport """
# startup apport just until the next reboot, it has the magic
# "force_start" environment for this
subprocess.call(["service","apport","start","force_start=1"])

are remove because they call apport.

Revision history for this message
Brian Murray (brian-murray) wrote :

To be clear removing the declaration of the function doDistUpgrade is incorrect and should be kept.

Revision history for this message
Brian Murray (brian-murray) wrote :

I've uploaded the fix for this issue to the ubuntu-release-upgrader bzr branch.

Unmerged revisions

2590. By Benjamin Kerensa

Drop Apport Enablement Code

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches