Merge lp://qastaging/~bkerensa/unity/fix-for-934526 into lp://qastaging/unity

Proposed by Benjamin Kerensa
Status: Merged
Approved by: Tim Penhey
Approved revision: no longer in the source branch.
Merged at revision: 2216
Proposed branch: lp://qastaging/~bkerensa/unity/fix-for-934526
Merge into: lp://qastaging/unity
Diff against target: 11 lines (+1/-1)
1 file modified
plugins/unityshell/unityshell.xml.in (+1/-1)
To merge this branch: bzr merge lp://qastaging/~bkerensa/unity/fix-for-934526
Reviewer Review Type Date Requested Status
Marco Biscaro (community) Approve
Adolfo Jayme Barrientos (community) Approve
Didier Roche-Tolomelli Pending
Review via email: mp+99045@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-03-23.

Commit message

Update tooltip in ccsm for "Show Desktop Icon".

Description of the change

In error I thought that the "icon" being of a different case was the typo since all other instances of words have upper-case but I have now fixed "Desktop" and additionally have left icon so it matches case use.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote : Posted in a previous version of this proposal

Thanks a lot for your work here, approving :)

review: Approve
Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote : Posted in a previous version of this proposal

I still see "Dekstop" instead of "Desktop", or there's something I miss?

review: Needs Fixing
Revision history for this message
Marco Biscaro (marcobiscaro2112) wrote : Posted in a previous version of this proposal

Yes, it is not fixed.

review: Needs Fixing
Revision history for this message
Benjamin Kerensa (bkerensa) wrote :

Sorry about the confusion this should now be fixed and I have adjust the description of the change to reflect why it was not appropriately fixed the first time.

Revision history for this message
Unity Merger (unity-merger) wrote : Posted in a previous version of this proposal

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote : Posted in a previous version of this proposal

Better, thanks! :)

review: Approve
Revision history for this message
Adolfo Jayme Barrientos (fitojb) wrote :

Thanks!

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Revision history for this message
Marco Biscaro (marcobiscaro2112) wrote :

It looks better now!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.