checkbox-certification

Merge lp://qastaging/~bladernr/checkbox-certification/cert-add-cert-whitelist into lp://qastaging/checkbox-certification

  1. cert-add-cert-whitelist
  2. Merge into trunk
Proposed by Jeff Lane 
Status: Merged
Merge reported by: Marc Tardif
Merged at revision: not available
Proposed branch: lp://qastaging/~bladernr/checkbox-certification/cert-add-cert-whitelist
Merge into: lp://qastaging/checkbox-certification
Diff against target: 90 lines (+12/-10)
5 files modified
jobs/certification.txt (+1/-1)
jobs/cpu.txt (+5/-3)
jobs/hardware.txt (+2/-2)
jobs/kernel.txt (+2/-2)
jobs/sru_suite.txt (+2/-2)
To merge this branch: bzr merge lp://qastaging/~bladernr/checkbox-certification/cert-add-cert-whitelist
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Review via email: mp+48270@code.qastaging.launchpad.net

Description of the change

Certification Whitelist In tha HOUSE.

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote :

Any particular reason why the acpi_sleep job was renamed to acpi_sleep_attachment? For example, was it conflicting with another job?

review: Needs Information
Revision history for this message
Jeff Lane  (bladernr) wrote :

On 02/02/2011 12:18 PM, Marc Tardif wrote:
> Review: Needs Information
> Any particular reason why the acpi_sleep job was renamed to acpi_sleep_attachment? For example, was it conflicting with another job?

actually, I forgot to change the rest of them...

That one was changed for consistency sake, since I also changed all the
attachment jobs in base to *_attach I meant to change all the ones in
-cert to match. I failed that bit of consistency as it was a last
minute addition while playing with the whitelist...

It does not currently conflict with any actual test job, however, who
knows what could happen in the future... I found conflicts in base,
which prompted the renaming...

--
Jeff Lane - Hardware Certification Engineer and Test Tools Developer
Ubuntu Ham: W4KDH
Freenode IRC: bladernr or bladernr_
gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417 C466 4ABD 3635 3A14 B2DD

lp://qastaging/~bladernr/checkbox-certification/cert-add-cert-whitelist updated
325. By Jeff Lane 

Created seperate whitelists for client and server certification

Revision history for this message
Marc Tardif (cr3) wrote :

Looks good and took the opportunity to rename a few jobs:

sru_attach_screenshot -> sru_screenshot_attachment
sru_xorg-failsafe -> sru_xorg_failsafe
sru_xorg-process -> sru_xorg_process
sru_fwts-wakealarm -> sru_fwts_wakealarm

And made sure to update the whitelists accordingly.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches