Merge lp://qastaging/~bladernr/checkbox/1077008-volume_test into lp://qastaging/checkbox
Proposed by
Jeff Lane
Status: | Merged |
---|---|
Approved by: | Zygmunt Krynicki |
Approved revision: | 1819 |
Merged at revision: | 1820 |
Proposed branch: | lp://qastaging/~bladernr/checkbox/1077008-volume_test |
Merge into: | lp://qastaging/checkbox |
Diff against target: |
103 lines (+17/-11) 2 files modified
debian/changelog (+2/-0) scripts/volume_test (+15/-11) |
To merge this branch: | bzr merge lp://qastaging/~bladernr/checkbox/1077008-volume_test |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zygmunt Krynicki (community) | Approve | ||
Jeff Lane | Needs Resubmitting | ||
Daniel Manrique (community) | Approve | ||
Review via email:
|
Description of the change
Changes Volume Test so that it no longer fails when maxvol <= volume >= minvol. Now it only fails when maxvol < volume > minvol
Thus, if we say Max vol is 99 and volume is 99, it'll pass. If we say minvol is 50 and volume is 49, it'll fail.
To post a comment you must log in.
We could run this by mfisch (original test author) so that he can confirm this doesn't change their expectations. Other than that, this change makes a lot of sense.