Merge lp://qastaging/~bladernr/checkbox/1629417-fix-power-ipmitest into lp://qastaging/checkbox
Proposed by
Jeff Lane
| Status: | Merged |
|---|---|
| Approved by: | Jeff Lane |
| Approved revision: | 4514 |
| Merged at revision: | 4514 |
| Proposed branch: | lp://qastaging/~bladernr/checkbox/1629417-fix-power-ipmitest |
| Merge into: | lp://qastaging/checkbox |
| Diff against target: |
43 lines (+12/-8) 1 file modified
providers/plainbox-provider-checkbox/bin/ipmi_test (+12/-8) |
| To merge this branch: | bzr merge lp://qastaging/~bladernr/checkbox/1629417-fix-power-ipmitest |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Larson | Approve | ||
|
Review via email:
|
|||
Description of the change
Modifies the ipmi_test script so it no longer fails if a module fails to load. This is because some arches don't use the same modules. Thus on Power, the script was failing because ipmi_si was failing, but power uses ipmi_devintf and ipmi_ssif instead.
So now the script will just warn on module failure, and move on to attempting comms with the BMC. If THAT fails the script will still return a fail code.
This has been tested on a failing OpenPower system as well as an x86 system (to ensure it doesn't break there).
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This seems reasonable to me, but I don't have a good way to test it myself. As you say you've tested it on the affected system though I'm +1. At the very least, module loading failures shouldn't prevent any currently-working systems from continuing to run, even given the new modules that you load.