Checkbox

Merge lp://qastaging/~bladernr/checkbox/checkbox-merge-ocp-block_device_resource into lp://qastaging/checkbox

checkbox-merge-ocp-block_device_resource
Merge into trunk

Proposed by Jeff Lane  on 2015-08-14

Status:	Merged
Approved by:	Daniel Manrique on 2015-08-20
Approved revision:	3956
Merged at revision:	3955
Proposed branch:	lp://qastaging/~bladernr/checkbox/checkbox-merge-ocp-block_device_resource
Merge into:	lp://qastaging/checkbox
Diff against target:	70 lines (+23/-5) 1 file modified providers/plainbox-provider-resource-generic/bin/block_device_resource (+23/-5)
To merge this branch:	bzr merge lp://qastaging/~bladernr/checkbox/checkbox-merge-ocp-block_device_resource
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel Manrique (community)		2015-08-14	Approve on 2015-08-20
Review via email: mp+268144@code.qastaging.launchpad.net

Description of the change

Adds an addition to block_device_resource that checks

/sys/block/sdX/device/block/sdX/queue/rotational

which should report 1 if the device is rotational (HDD) or 0 if the device is non-rotational (SSD)

Here is sample output from a desktop machine with a platter drive:
sda_state: internal
sda_usb2: unsupported
sda_usb3: unsupported
sda_rotation: yes

sr0_state: removable
sr0_usb2: unsupported
sr0_usb3: unsupported
sr0_rotation: yes

and here is one from a NUC with an mSATA SSD:
sda_state: internal
sda_usb2: unsupported
sda_usb3: unsupported
sda_rotation: no

This is helpful for server as we plan on adding a test to check for a kernel TRIM bug on SSDs for 16.04.

Revision history for this message

Jeff Lane  (bladernr) wrote on 2015-08-14:

Note, this is picked from a modified version of block_device_resource that OCP created so this also brings OCP back in line with checkbox proper.

lp://qastaging/~bladernr/checkbox/checkbox-merge-ocp-block_device_resource updated on 2015-08-20

3946. By Zygmunt Krynicki on 2015-08-17: "automatic merge of lp:~zyga/checkbox/move-cert-providers-to-git/ by tarmac [r=kissiel][bug=][author=zyga]"
3947. By Po-Hsu Lin on 2015-08-18: "automatic merge of lp:~cypressyew/checkbox/sync-test-after-s3-oops/ by tarmac [r=zyga][bug=1485439][author=cypressyew]"
3948. By Po-Hsu Lin on 2015-08-18: "automatic merge of lp:~cypressyew/checkbox/sync-test-after-s3-ext-audio/ by tarmac [r=zyga][bug=1485451][author=cypressyew]"
3949. By Maciej Kisielewski on 2015-08-18: "automatic merge of lp:~kissiel/checkbox/comments-in-cbt/ by tarmac [r=zyga,brendan-donegan][bug=][author=kissiel]"
3950. By Jeff Lane  on 2015-08-18: "automatic merge of lp:~bladernr/checkbox/1486089-efi-only-x86/ by tarmac [r=zyga][bug=1486089][author=bladernr]"
3951. By Launchpad Translations on behalf of checkbox-dev on 2015-08-19: Launchpad automatic translations update.
3952. By Jeff Lane  on 2015-08-19: "automatic merge of lp:~bladernr/checkbox/checkbox-replace-disk-detect/ by tarmac [r=zyga][bug=1483829][author=bladernr]"
3953. By Sylvain Pineau on 2015-08-20: "automatic merge of lp:~kissiel/checkbox/mandatory-jobs/ by tarmac [r=zyga][bug=1391774][author=kissiel]"
3954. By Po-Hsu Lin on 2015-08-20: "automatic merge of lp:~cypressyew/checkbox/sync-test-after-s3-input/ by tarmac [r=zyga][bug=1486338][author=cypressyew]"
3956. By Jeff Lane  on 2015-08-20: Rebased on current checkbox trunk. Review suggestions made and pep8 fixes implemented