Merge lp://qastaging/~bladernr/checkbox/clarify-cd_dvd-write-tests into lp://qastaging/checkbox

Proposed by Jeff Lane 
Status: Merged
Merged at revision: 1125
Proposed branch: lp://qastaging/~bladernr/checkbox/clarify-cd_dvd-write-tests
Merge into: lp://qastaging/checkbox
Diff against target: 21 lines (+2/-2)
1 file modified
jobs/optical.txt.in (+2/-2)
To merge this branch: bzr merge lp://qastaging/~bladernr/checkbox/clarify-cd_dvd-write-tests
Reviewer Review Type Date Requested Status
Brendan Donegan (community) Approve
Jeff Lane  Needs Resubmitting
Review via email: mp+82350@code.qastaging.launchpad.net

Description of the change

Clarified the intent of the cd-write and dvd-write tests in optical.txt. Now they specifically say "If your drive doesnt support this, skip this test"

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Do we want to say 'or if you don't have any writable media available then please skip the test?'. It should be obvious, but might be worth stating explicitly.

review: Needs Information
Revision history for this message
Jeff Lane  (bladernr) wrote :

Sounds like a good idea. Strings tweaked accordingly.

review: Needs Resubmitting
1126. By Jeff Lane 

added further skip conditions to be absolutely clear

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Looks nice, approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches