Merge lp://qastaging/~bladernr/checkbox/expand-config-file-explanations into lp://qastaging/~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification

Proposed by Jeff Lane 
Status: Merged
Approved by: Daniel Manrique
Approved revision: 11
Merged at revision: 11
Proposed branch: lp://qastaging/~bladernr/checkbox/expand-config-file-explanations
Merge into: lp://qastaging/~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification
Diff against target: 49 lines (+24/-7)
1 file modified
debian/extras/canonical-certification-config/canonical-certification.conf (+24/-7)
To merge this branch: bzr merge lp://qastaging/~bladernr/checkbox/expand-config-file-explanations
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Zygmunt Krynicki (community) Approve
Review via email: mp+217469@code.qastaging.launchpad.net

Description of the change

Expands on the explanations for virtualization and network testing to answer commonly asked questions from testers about which variables are needed and when to use them.

Expands the welcome message to remind testers to be sure they have edited /etc/xdg/canonical-certification.conf before testing starts.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

More docs are always welcome. Thanks Jeff

review: Approve
Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks good, thanks!

The VM timeout (3000 seconds) seems both a bit high (almost an hour) and strangely arbitrary (50 minutes, why not an hour or 45 minutes). I seem to remember the test waited this time regardless of whether the VM booted in seconds. I may be wrong here, so I don't want to necessarily ask for a change, but we should try to see how this works in pratice and maybe change it later.

review: Approve
Revision history for this message
Jeff Lane  (bladernr) wrote :

FWIW, the 3000 second timeout that I put in the config file just
matches the default timeout that Marcom put into the script
initially... I just set the variable because leaving it blank was
causing issues with running the test :(

we can certainly revisit that in the future though for a more
reasonable timeout setting all the way around. I'll file a bug for
that now.

On Mon, Apr 28, 2014 at 11:51 AM, <email address hidden> wrote:
> The proposal to merge lp:~bladernr/checkbox/expand-config-file-explanations into lp:~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification has been updated.
>
> Status: Approved => Merged
>
> For more details, see:
> https://code.launchpad.net/~bladernr/checkbox/expand-config-file-explanations/+merge/217469
> --
> https://code.launchpad.net/~bladernr/checkbox/expand-config-file-explanations/+merge/217469
> You are the owner of lp:~bladernr/checkbox/expand-config-file-explanations.

--
"Entropy isn't what it used to be."

Jeff Lane - Server Certification Team Lead, Tools Developer, Warrior
Poet, Lover of Pie
Ubuntu Ham: W4KDH
Freenode IRC: bladernr or bladernr_
gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417 C466 4ABD 3635 3A14 B2DD

Revision history for this message
Jeff Lane  (bladernr) wrote :

Nevermind, I must be on crack. I could have sworn that this had a
3000 second default timeout to give ample time for the image to
boot... :/ I'll fix it some other time... doesn't hurt anything for
now. Sheesh... now I'm imagining numbers...

On Mon, Apr 28, 2014 at 2:05 PM, Jeffrey Lane
<email address hidden> wrote:
> FWIW, the 3000 second timeout that I put in the config file just
> matches the default timeout that Marcom put into the script
> initially... I just set the variable because leaving it blank was
> causing issues with running the test :(
>
> we can certainly revisit that in the future though for a more
> reasonable timeout setting all the way around. I'll file a bug for
> that now.
>
> On Mon, Apr 28, 2014 at 11:51 AM, <email address hidden> wrote:
>> The proposal to merge lp:~bladernr/checkbox/expand-config-file-explanations into lp:~checkbox-dev/checkbox/ppa-packaging-plainbox-provider-canonical-certification has been updated.
>>
>> Status: Approved => Merged
>>
>> For more details, see:
>> https://code.launchpad.net/~bladernr/checkbox/expand-config-file-explanations/+merge/217469
>> --
>> https://code.launchpad.net/~bladernr/checkbox/expand-config-file-explanations/+merge/217469
>> You are the owner of lp:~bladernr/checkbox/expand-config-file-explanations.
>
>
>
> --
> "Entropy isn't what it used to be."
>
> Jeff Lane - Server Certification Team Lead, Tools Developer, Warrior
> Poet, Lover of Pie
> Ubuntu Ham: W4KDH
> Freenode IRC: bladernr or bladernr_
> gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417 C466 4ABD 3635 3A14 B2DD

--
"Entropy isn't what it used to be."

Jeff Lane - Server Certification Team Lead, Tools Developer, Warrior
Poet, Lover of Pie
Ubuntu Ham: W4KDH
Freenode IRC: bladernr or bladernr_
gpg: 1024D/3A14B2DD 8C88 B076 0DD7 B404 1417 C466 4ABD 3635 3A14 B2DD

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches