Merge lp://qastaging/~blake-rouse/maas/bulk-action-feedback into lp://qastaging/~maas-committers/maas/trunk
Proposed by
Blake Rouse
| Status: | Merged |
|---|---|
| Approved by: | Blake Rouse |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 3875 |
| Proposed branch: | lp://qastaging/~blake-rouse/maas/bulk-action-feedback |
| Merge into: | lp://qastaging/~maas-committers/maas/trunk |
| Diff against target: |
404 lines (+223/-12) 5 files modified
src/maasserver/static/css/maas-styles.css (+1/-1) src/maasserver/static/js/angular/controllers/nodes_list.js (+50/-4) src/maasserver/static/js/angular/controllers/tests/test_nodes_list.js (+125/-0) src/maasserver/static/partials/nodes-list.html (+42/-7) src/maasserver/static/scss/maas/components/_forms.scss (+5/-0) |
| To merge this branch: | bzr merge lp://qastaging/~blake-rouse/maas/bulk-action-feedback |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Raphaël Badin (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Show progress and error messages when performing bulk actions. Disable the checkboxes when actions are being performed in the node listing.
This gives feedback to the user allowing them see the actions as they are being performed. Also gives them the ability to see action errors, which use to just be logged to the browser console.
To post a comment you must log in.
Revision history for this message
| Blake Rouse (blake-rouse) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good! A couple of remarks but nothing major.