Merge lp://qastaging/~blake-rouse/maas/fix-1441864 into lp://qastaging/~maas-committers/maas/trunk
Proposed by
Blake Rouse
| Status: | Merged |
|---|---|
| Approved by: | Blake Rouse |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 3989 |
| Proposed branch: | lp://qastaging/~blake-rouse/maas/fix-1441864 |
| Merge into: | lp://qastaging/~maas-committers/maas/trunk |
| Prerequisite: | lp://qastaging/~blake-rouse/maas/fix-1443959 |
| Diff against target: |
309 lines (+140/-19) 6 files modified
src/maasserver/static/js/angular/controllers/nodes_list.js (+2/-2) src/maasserver/static/js/angular/controllers/tests/test_nodes_list.js (+2/-2) src/maasserver/static/js/angular/filters/nodes.js (+37/-11) src/maasserver/static/js/angular/filters/tests/test_nodes.js (+23/-0) src/maasserver/static/js/angular/services/search.js (+25/-4) src/maasserver/static/js/angular/services/tests/test_search.js (+51/-0) |
| To merge this branch: | bzr merge lp://qastaging/~blake-rouse/maas/fix-1441864 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mike Pontillo (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Use exact matcher on all filters and enable the exact matcher in the nodesFilter.
This fixes issues where filtering by an item that was a subset of another item would show both matching nodes for that item.
To post a comment you must log in.
Revision history for this message
| Blake Rouse (blake-rouse) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks great. (I loaded this up in the dev environment and tested it for awhile.)
The only bug I found was that if I type:
status:(=allocated)
And then click the "Allocated" filter, I get:
status:
But I bet that's a pre-existing issue.