MAAS

Merge lp://qastaging/~blake-rouse/maas/is-importing into lp://qastaging/~maas-committers/maas/trunk

  1. is-importing
  2. Merge into trunk
Proposed by Blake Rouse
Status: Merged
Approved by: Blake Rouse
Approved revision: no longer in the source branch.
Merged at revision: 5591
Proposed branch: lp://qastaging/~blake-rouse/maas/is-importing
Merge into: lp://qastaging/~maas-committers/maas/trunk
Diff against target: 43 lines (+16/-0)
2 files modified
src/maasserver/api/boot_resources.py (+6/-0)
src/maasserver/api/tests/test_boot_resources.py (+10/-0)
To merge this branch: bzr merge lp://qastaging/~blake-rouse/maas/is-importing
Reviewer Review Type Date Requested Status
Mike Pontillo (community) Approve
Review via email: mp+312591@code.qastaging.launchpad.net

Commit message

Add is_importing call to boot resources API.

To post a comment you must log in.
Revision history for this message
Mike Pontillo (mpontillo) wrote :

LGTM!

review: Approve
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

I know this is merged, and thanks - but wouldn't it be nicer if this returned JSON? I'll make do in the meantime but writing something like:

if output == 'false':

is just... wrong

Revision history for this message
Gavin Panella (allenap) wrote :

That is JSON:

  >>> import json
  >>> json.loads("false")
  False

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Oops, thanks

On Wed, 7 Dec 2016 at 10:22 Gavin Panella <email address hidden>
wrote:

> That is JSON:
>
> >>> import json
> >>> json.loads("false")
> False
>
> --
> https://code.launchpad.net/~blake-rouse/maas/is-importing/+merge/312591
> You are subscribed to branch lp:maas.
>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.