Merge lp://qastaging/~bloodearnest/charm-helpers/ppa-tools into lp://qastaging/charm-helpers

14:56 <bloodearnest> https://code.launchpad.net/~bloodearnest/charm-helpers/ppa-tools/+merge/175308
14:56 <bloodearnest> be nice if we could a "shared pipeline" for a fast moving dep branch like that
14:57 <noodles> Yeah
14:57 <noodles> Nice branch!
14:58 <bloodearnest> simple functions
14:58 <noodles> I think mock expectations are used a bit much in charmhelpers... what I've been doing...
14:58 * noodles checks on his own MP
14:58 <bloodearnest> I think a mock filesystem would be better
15:00 <noodles> Yeah - well, I'm not sure if it's what you mean, but you can do that really easily...
15:00 <noodles> If you look at test_updates_existing_values()
15:00 <noodles> Teh actual code writes a file to /etc/salt/grains
15:01 <noodles> But the test can just mock the path to the grains file with a tmp directory, then the rest of the test is on the actual filesystem.
15:01 <bloodearnest> looking
15:31 <bloodearnest> hmm - not sure how to apply the tmp dir to my test, as the path is a hardcoded one
15:31 <noodles> Oh - you can't make it a module-level path? Yeah, that doesn't work then.
15:32 <bloodearnest> I could, I guess
15:32 <bloodearnest> python needs better whole fs mocking tools
15:32 <noodles> I love mock - so much better than what was available before...
15:35 <bloodearnest> mock is great
15:35 <bloodearnest> I loved how easy it was to mock my new hooks logic with self.mock_charmhelpers
15:35 <noodles> Yeah!

Hi, Simon. Thanks for the MP!

Although there are vestigial helpers for package management in charmhelpers.core, this functionality should live in charmhelpers.fetch. Would you mind reshuffling and resubmitting?

Thanks.