MAAS

Merge ~blr/maas:compose-kvm-networking into maas:master

Proposed by Kit Randel on 2018-09-13

Status:

Merged

Approved by:

Kit Randel on 2018-09-25

Approved revision:

3d947a4636340a391ab3b4d9079a7906349f8cd0

Merge reported by:

MAAS Lander

Merged at revision:

not available

Proposed branch:

~blr/maas:compose-kvm-networking

Merge into:

maas:master

Diff against target:

532 lines (+344/-12)

4 files modified

src/maasserver/static/js/angular/controllers/pod_details.js (+75/-7)
src/maasserver/static/js/angular/controllers/tests/test_pod_details.js (+138/-5)
src/maasserver/static/partials/pod-details.html (+87/-0)
src/maasserver/static/scss/_tables.scss (+44/-0)

Related bugs:

Bug #1660418: Uploading a new custom image does not remove the old image	High	Fix Released
Bug #1793497: [2.5] Composing from a pod with custom interfaces from the UI fails	High	Fix Released

Link a bug report

Reviewer	Date Requested	Status
Mike Pontillo (community)	2018-09-13	Approve on 2018-09-25
Newell Jensen (community)		Approve on 2018-09-21
Review via email: mp+354846@code.qastaging.launchpad.net

Commit message

Add KVM pod interfaces by subnet.

Description of the change

The first in a series of branches to implement this feature. To come in future branches: spaces, multicolumn dropdown (as per Martin's designs), PXE indicator, manual IP allocation.

screenshot: https://drive.google.com/file/d/11Ls--bgeQc2dZ1jx394SclBkCEjwP0f8/view

Revision history for this message

Newell Jensen (newell-jensen) wrote on 2018-09-21:

+1 code wise but not sure if this matches what design has agreed upon. Setting to approved but would like someone else on the MAAS team to test and someone from UI team to approve before this gets landed.

One inline comment below, might be lint related?

review: Approve

Revision history for this message

Mike Pontillo (mpontillo) wrote on 2018-09-25:

This looks like a great start! I was looking at this branch a little bit last week, but I just re-tested the latest version (thanks for the fixes).

About the default interface names: en* is more of an Apple convention (likely originating from BSD). Linux users would probably be more at home if we use "eth*" for interface names.

review: Approve

Revision history for this message

MAAS Lander (maas-lander) wrote on 2018-09-25:

LANDING
-b compose-kvm-networking lp:~blr/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED BUILD
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/3991/consoleText