Merge ~blr/maas:fix-1843771 into maas:2.6

Proposed by Kit Randel
Status: Merged
Approved by: Kit Randel
Approved revision: 35b5a029807e4ba71a1d2a2545207f828023a954
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~blr/maas:fix-1843771
Merge into: maas:2.6
Diff against target: 13 lines (+1/-1)
1 file modified
src/maasserver/static/partials/machines-table.html (+1/-1)
Reviewer Review Type Date Requested Status
Steve Rydz (community) Approve
MAAS Lander Approve
Lilyana Videnova Pending
MAAS Maintainers Pending
Review via email: mp+373287@code.qastaging.launchpad.net

Commit message

* Only display 'show all' if more machines than display limit.
* Increase machine group display limit to 10 machines.

Description of the change

## Display limit increase
Initial benchmarking suggests that there isn't a significant cost to increasing the machine group display limit from 5 to 10 machines on render, however there is a larger perceived delay (imo) when switching tabs. Please make a judgement on this when QAing (switch from Devices to Machines).

## QA
Ensure you have more than 5 machines for a given group, you should only see a "show all" link displayed for that group.

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b fix-1843771 lp:~blr/maas/+git/maas into -b 2.6 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 8a2059912b4f0f1f09c756066a36da1243ccdd45

review: Approve
Revision history for this message
Steve Rydz (steverydz) wrote :

LGTM +1

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches