Dekko

Merge lp://qastaging/~bobo-324/dekko/customScheme into lp://qastaging/dekko/0.3

  1. customScheme
  2. Merge into 0.3
Proposed by Boren Zhang
Status: Merged
Merged at revision: 172
Proposed branch: lp://qastaging/~bobo-324/dekko/customScheme
Merge into: lp://qastaging/dekko/0.3
Diff against target: 197 lines (+106/-3)
8 files modified
CMakeLists.txt (+1/-0)
qml/MessageView/HtmlPart.qml (+5/-1)
qml/MessageView/ImagePart.qml (+3/-2)
qml/MessageView/OneMessagePage.qml (+1/-0)
src/app/Network/MsgPartNetAccessManagerFactory.cpp (+45/-0)
src/app/Network/MsgPartNetAccessManagerFactory.h (+43/-0)
src/app/PartWidget/NewPartWidget.cpp (+3/-0)
src/app/main.cpp (+5/-0)
To merge this branch: bzr merge lp://qastaging/~bobo-324/dekko/customScheme
Reviewer Review Type Date Requested Status
Dan Chapman  Approve
Review via email: mp+243318@code.qastaging.launchpad.net

Description of the change

This patch let you view cid image in html message by registering a networkAccessManagerFactory( MsgPartNetworkAccessFactory) to QMLEngin.

MsgPartNetworkAccessFactory is register as a context property "msgPartNetworkAccessFactory", so that we can set message modelIndex using function "msgPartNetworkAccessFactory.setMessageIndex()" in QML before displaying html message.

Using msgPartNetworkAccessFactory.setMessageIndex() will send messageIndex to all networkAccessManager that has been created. Because they will reuse networkAccessManager for different account.

Previewing image should also work now.

To post a comment you must log in.
Revision history for this message
Dan Chapman  (dpniel) wrote :

LGTM and works as expected. We should get a bug filed though for oxide not liking the the text/html; charset... bug. It would be much better to just give oxide the trojita-imap url here. Anyway it's working for now :-D \o/ no more QtWebkit in our future!!

Thanks for your work on this

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: