Merge lp://qastaging/~bogdana/landscape-client/mocker-monitor-test-memoryinfo into lp://qastaging/~landscape/landscape-client/trunk

Proposed by Bogdana Vereha
Status: Merged
Approved by: Bogdana Vereha
Approved revision: 848
Merged at revision: 852
Proposed branch: lp://qastaging/~bogdana/landscape-client/mocker-monitor-test-memoryinfo
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 30 lines (+7/-7)
1 file modified
landscape/monitor/tests/test_memoryinfo.py (+7/-7)
To merge this branch: bzr merge lp://qastaging/~bogdana/landscape-client/mocker-monitor-test-memoryinfo
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Approve
Chris Glass (community) Approve
Chad Smith Approve
Review via email: mp+297515@code.qastaging.launchpad.net

Commit message

Update monitor.tests.test_memoryinfo to use mock.

Description of the change

Update monitor.tests.test_memoryinfo to use mock.

Testing instructions:
Unit tests

To post a comment you must log in.
Revision history for this message
Chad Smith (chad.smith) wrote :

+1 looks good.

review: Approve
848. By Bogdana Vereha

Use assert_called_once_with instead of called_with

Revision history for this message
Chris Glass (tribaal) wrote :

+1!

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :
review: Approve (test results)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: