Landscape Client

Merge lp://qastaging/~bogdana/landscape-client/mocker-package-test-store into lp://qastaging/~landscape/landscape-client/trunk

  1. mocker-package-test-store
  2. Merge into trunk
Proposed by Bogdana Vereha
Status: Merged
Approved by: Bogdana Vereha
Approved revision: 876
Merged at revision: 881
Proposed branch: lp://qastaging/~bogdana/landscape-client/mocker-package-test-store
Merge into: lp://qastaging/~landscape/landscape-client/trunk
Diff against target: 95 lines (+16/-50)
1 file modified
landscape/package/tests/test_store.py (+16/-50)
To merge this branch: bzr merge lp://qastaging/~bogdana/landscape-client/mocker-package-test-store
Reviewer Review Type Date Requested Status
Geoff Teale (community) Approve
Chad Smith Approve
🤖 Landscape Builder test results Approve
Review via email: mp+297572@code.qastaging.launchpad.net

Commit message

Update package.test_store to use mock instead of mocker

Description of the change

Update package.test_store to use mock instead of mocker

Testing instructions:
unittests

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: TRIAL_ARGS=-j4 make check
Result: Success
Revno: 875
Branch: lp:~bogdana/landscape-client/mocker-package-test-store
Jenkins: https://ci.lscape.net/job/latch-test/5072/

review: Approve (test results)
Revision history for this message
Chad Smith (chad.smith) wrote :

+1 minor assertEqual nits. Excellent use of context manager.

review: Approve
Revision history for this message
Geoff Teale (tealeg) wrote :

+1 I'm afraid Chad's right re the order of parameters in assertions.

review: Approve
lp://qastaging/~bogdana/landscape-client/mocker-package-test-store updated
876. By Bogdana Vereha

Reverse param order in assert

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: